Skip to content

Commit 7e20049

Browse files
compudjguoren83
authored andcommitted
Revert "csky: Add support for restartable sequence"
This reverts commit 9866d14. The csky rseq support has been merged without ever notifying the rseq maintainers, and without any of the required asssembler glue in the rseq selftests, which means it is entirely untested. It is also derived from a non-upstream riscv patch which has known bugs. The assembly part of this revert should be carefully reviewed by the architecture maintainer because it touches code which has changed since the merge of the reverted patch. The rseq selftests assembly glue should be introduced at the same time as the architecture rseq support. Without the presence of any test, I recommend reverting rseq support from csky for now. Link: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Mathieu Desnoyers <[email protected]> Signed-off-by: Guo Ren <[email protected]> Cc: Al Viro <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: [email protected]
1 parent c5e7ee7 commit 7e20049

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

arch/csky/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ config CSKY
9494
select HAVE_PERF_USER_STACK_DUMP
9595
select HAVE_DMA_CONTIGUOUS
9696
select HAVE_REGS_AND_STACK_ACCESS_API
97-
select HAVE_RSEQ
9897
select HAVE_STACKPROTECTOR
9998
select HAVE_SYSCALL_TRACEPOINTS
10099
select MAY_HAVE_SPARSE_IRQ

arch/csky/kernel/entry.S

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,6 @@ ENTRY(csky_systemcall)
5050
SAVE_ALL TRAP0_SIZE
5151
zero_fp
5252
context_tracking
53-
#ifdef CONFIG_RSEQ_DEBUG
54-
mov a0, sp
55-
jbsr rseq_syscall
56-
#endif
5753
psrset ee, ie
5854

5955
lrw r9, __NR_syscalls

arch/csky/kernel/signal.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs)
179179
sigset_t *oldset = sigmask_to_save();
180180
int ret;
181181

182-
rseq_signal_deliver(ksig, regs);
183-
184182
/* Are we from a system call? */
185183
if (in_syscall(regs)) {
186184
/* Avoid additional syscall restarting via ret_from_exception */

0 commit comments

Comments
 (0)