Skip to content

Commit 7e2ce0c

Browse files
committed
NFSD: Move documenting comment for nfsd4_process_open2()
Clean up nfsd4_open() by converting a large comment at the only call site for nfsd4_process_open2() to a kerneldoc comment in front of that function. Signed-off-by: Chuck Lever <[email protected]>
1 parent 26320d7 commit 7e2ce0c

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

fs/nfsd/nfs4proc.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -628,11 +628,7 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
628628
status = nfserr_inval;
629629
goto out;
630630
}
631-
/*
632-
* nfsd4_process_open2() does the actual opening of the file. If
633-
* successful, it (1) truncates the file if open->op_truncate was
634-
* set, (2) sets open->op_stateid, (3) sets open->op_delegation.
635-
*/
631+
636632
status = nfsd4_process_open2(rqstp, resfh, open);
637633
WARN(status && open->op_created,
638634
"nfsd4_process_open2 failed to open newly-created file! status=%u\n",

fs/nfsd/nfs4state.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5448,6 +5448,18 @@ static void nfsd4_deleg_xgrade_none_ext(struct nfsd4_open *open,
54485448
*/
54495449
}
54505450

5451+
/**
5452+
* nfsd4_process_open2 - finish open processing
5453+
* @rqstp: the RPC transaction being executed
5454+
* @current_fh: NFSv4 COMPOUND's current filehandle
5455+
* @open: OPEN arguments
5456+
*
5457+
* If successful, (1) truncate the file if open->op_truncate was
5458+
* set, (2) set open->op_stateid, (3) set open->op_delegation.
5459+
*
5460+
* Returns %nfs_ok on success; otherwise an nfs4stat value in
5461+
* network byte order is returned.
5462+
*/
54515463
__be32
54525464
nfsd4_process_open2(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_open *open)
54535465
{

0 commit comments

Comments
 (0)