Skip to content

Commit 7e5d6cf

Browse files
committed
EDAC/amd64: Do not warn when removing instances
On machines which do not populate all nodes with DIMMs, the driver doesn't initialize an instance there. However, the instance removal remove_one_instance() path will warn unconditionally, which is wrong. Remove the WARN_ON() even if the warning is innocent because it causes a splat in dmesg. Signed-off-by: Borislav Petkov <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 6cd1845 commit 7e5d6cf

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/edac/amd64_edac.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3573,9 +3573,6 @@ static void remove_one_instance(unsigned int nid)
35733573
struct mem_ctl_info *mci;
35743574
struct amd64_pvt *pvt;
35753575

3576-
mci = find_mci_by_dev(&F3->dev);
3577-
WARN_ON(!mci);
3578-
35793576
/* Remove from EDAC CORE tracking list */
35803577
mci = edac_mc_del_mc(&F3->dev);
35813578
if (!mci)

0 commit comments

Comments
 (0)