Skip to content

Commit 7e8e667

Browse files
Andi Shytiwsakernel
authored andcommitted
i2c: owl: Use devm_clk_get_enabled()
Replace the pair of functions, devm_clk_get() and clk_prepare_enable(), with a single function devm_clk_get_enabled(). Signed-off-by: Andi Shyti <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 9d8b7b6 commit 7e8e667

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

drivers/i2c/busses/i2c-owl.c

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -461,21 +461,16 @@ static int owl_i2c_probe(struct platform_device *pdev)
461461
return -EINVAL;
462462
}
463463

464-
i2c_dev->clk = devm_clk_get(dev, NULL);
464+
i2c_dev->clk = devm_clk_get_enabled(dev, NULL);
465465
if (IS_ERR(i2c_dev->clk)) {
466-
dev_err(dev, "failed to get clock\n");
466+
dev_err(dev, "failed to enable clock\n");
467467
return PTR_ERR(i2c_dev->clk);
468468
}
469469

470-
ret = clk_prepare_enable(i2c_dev->clk);
471-
if (ret)
472-
return ret;
473-
474470
i2c_dev->clk_rate = clk_get_rate(i2c_dev->clk);
475471
if (!i2c_dev->clk_rate) {
476472
dev_err(dev, "input clock rate should not be zero\n");
477-
ret = -EINVAL;
478-
goto disable_clk;
473+
return -EINVAL;
479474
}
480475

481476
init_completion(&i2c_dev->msg_complete);
@@ -496,15 +491,10 @@ static int owl_i2c_probe(struct platform_device *pdev)
496491
i2c_dev);
497492
if (ret) {
498493
dev_err(dev, "failed to request irq %d\n", irq);
499-
goto disable_clk;
494+
return ret;
500495
}
501496

502497
return i2c_add_adapter(&i2c_dev->adap);
503-
504-
disable_clk:
505-
clk_disable_unprepare(i2c_dev->clk);
506-
507-
return ret;
508498
}
509499

510500
static const struct of_device_id owl_i2c_of_match[] = {

0 commit comments

Comments
 (0)