Skip to content

Commit 7e97685

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: mediatek: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/666127469482f9ca177805ff52aeb7bccb26e4c9.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 814dcce commit 7e97685

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

drivers/pci/controller/pcie-mediatek.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -365,19 +365,12 @@ static int mtk_pcie_config_read(struct pci_bus *bus, unsigned int devfn,
365365
{
366366
struct mtk_pcie_port *port;
367367
u32 bn = bus->number;
368-
int ret;
369368

370369
port = mtk_pcie_find_port(bus, devfn);
371-
if (!port) {
372-
*val = ~0;
370+
if (!port)
373371
return PCIBIOS_DEVICE_NOT_FOUND;
374-
}
375-
376-
ret = mtk_pcie_hw_rd_cfg(port, bn, devfn, where, size, val);
377-
if (ret)
378-
*val = ~0;
379372

380-
return ret;
373+
return mtk_pcie_hw_rd_cfg(port, bn, devfn, where, size, val);
381374
}
382375

383376
static int mtk_pcie_config_write(struct pci_bus *bus, unsigned int devfn,

0 commit comments

Comments
 (0)