Skip to content

Commit 7eb060a

Browse files
tammeladavem330
authored andcommitted
selftests: tc-testing: add more tests for sch_qfq
The QFQ qdisc class has parameter bounds that are not being checked for correctness. Acked-by: Jamal Hadi Salim <[email protected]> Signed-off-by: Pedro Tammela <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 2536989 commit 7eb060a

File tree

1 file changed

+72
-0
lines changed
  • tools/testing/selftests/tc-testing/tc-tests/qdiscs

1 file changed

+72
-0
lines changed

tools/testing/selftests/tc-testing/tc-tests/qdiscs/qfq.json

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,30 @@
4646
"$IP link del dev $DUMMY type dummy"
4747
]
4848
},
49+
{
50+
"id": "d364",
51+
"name": "Test QFQ with max class weight setting",
52+
"category": [
53+
"qdisc",
54+
"qfq"
55+
],
56+
"plugins": {
57+
"requires": "nsPlugin"
58+
},
59+
"setup": [
60+
"$IP link add dev $DUMMY type dummy || /bin/true",
61+
"$TC qdisc add dev $DUMMY handle 1: root qfq"
62+
],
63+
"cmdUnderTest": "$TC class add dev $DUMMY parent 1: classid 1:1 qfq weight 9999",
64+
"expExitCode": "2",
65+
"verifyCmd": "$TC class show dev $DUMMY",
66+
"matchPattern": "class qfq 1:1 root weight 9999 maxpkt",
67+
"matchCount": "0",
68+
"teardown": [
69+
"$TC qdisc del dev $DUMMY handle 1: root",
70+
"$IP link del dev $DUMMY type dummy"
71+
]
72+
},
4973
{
5074
"id": "8452",
5175
"name": "Create QFQ with class maxpkt setting",
@@ -70,6 +94,54 @@
7094
"$IP link del dev $DUMMY type dummy"
7195
]
7296
},
97+
{
98+
"id": "22df",
99+
"name": "Test QFQ class maxpkt setting lower bound",
100+
"category": [
101+
"qdisc",
102+
"qfq"
103+
],
104+
"plugins": {
105+
"requires": "nsPlugin"
106+
},
107+
"setup": [
108+
"$IP link add dev $DUMMY type dummy || /bin/true",
109+
"$TC qdisc add dev $DUMMY handle 1: root qfq"
110+
],
111+
"cmdUnderTest": "$TC class add dev $DUMMY parent 1: classid 1:1 qfq maxpkt 128",
112+
"expExitCode": "2",
113+
"verifyCmd": "$TC class show dev $DUMMY",
114+
"matchPattern": "class qfq 1:1 root weight 1 maxpkt 128",
115+
"matchCount": "0",
116+
"teardown": [
117+
"$TC qdisc del dev $DUMMY handle 1: root",
118+
"$IP link del dev $DUMMY type dummy"
119+
]
120+
},
121+
{
122+
"id": "92ee",
123+
"name": "Test QFQ class maxpkt setting upper bound",
124+
"category": [
125+
"qdisc",
126+
"qfq"
127+
],
128+
"plugins": {
129+
"requires": "nsPlugin"
130+
},
131+
"setup": [
132+
"$IP link add dev $DUMMY type dummy || /bin/true",
133+
"$TC qdisc add dev $DUMMY handle 1: root qfq"
134+
],
135+
"cmdUnderTest": "$TC class add dev $DUMMY parent 1: classid 1:1 qfq maxpkt 99999",
136+
"expExitCode": "2",
137+
"verifyCmd": "$TC class show dev $DUMMY",
138+
"matchPattern": "class qfq 1:1 root weight 1 maxpkt 99999",
139+
"matchCount": "0",
140+
"teardown": [
141+
"$TC qdisc del dev $DUMMY handle 1: root",
142+
"$IP link del dev $DUMMY type dummy"
143+
]
144+
},
73145
{
74146
"id": "d920",
75147
"name": "Create QFQ with multiple class setting",

0 commit comments

Comments
 (0)