Skip to content

Commit 7f48212

Browse files
jankaratytso
authored andcommitted
ext4: drop duplicate ea_inode handling in ext4_xattr_block_set()
ext4_xattr_block_set() drops ea_inode reference in two places. Handling it just under the 'cleanup' label is enough so drop the second occurence. Signed-off-by: Jan Kara <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Theodore Ts'o <[email protected]>
1 parent 8208c41 commit 7f48212

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

fs/ext4/xattr.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2158,17 +2158,6 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
21582158
ENTRY(header(s->base)+1));
21592159
if (error)
21602160
goto getblk_failed;
2161-
if (ea_inode) {
2162-
/* Drop the extra ref on ea_inode. */
2163-
error = ext4_xattr_inode_dec_ref(handle,
2164-
ea_inode);
2165-
if (error)
2166-
ext4_warning_inode(ea_inode,
2167-
"dec ref error=%d",
2168-
error);
2169-
iput(ea_inode);
2170-
ea_inode = NULL;
2171-
}
21722161

21732162
lock_buffer(new_bh);
21742163
error = ext4_journal_get_create_access(handle, sb,

0 commit comments

Comments
 (0)