Skip to content

Commit 7f6707a

Browse files
Qais YousefKAGA-KOKO
authored andcommitted
sparc: Replace cpu_up/down() with add/remove_cpu()
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down(). See commit a6717c0 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down() a private interface of the CPU subsystem. Signed-off-by: Qais Yousef <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Acked-by: David S. Miller <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 4d37cc2 commit 7f6707a

File tree

1 file changed

+2
-2
lines changed
  • arch/sparc/kernel

1 file changed

+2
-2
lines changed

arch/sparc/kernel/ds.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,7 @@ static int dr_cpu_configure(struct ds_info *dp, struct ds_cap_state *cp,
555555

556556
printk(KERN_INFO "ds-%llu: Starting cpu %d...\n",
557557
dp->id, cpu);
558-
err = cpu_up(cpu);
558+
err = add_cpu(cpu);
559559
if (err) {
560560
__u32 res = DR_CPU_RES_FAILURE;
561561
__u32 stat = DR_CPU_STAT_UNCONFIGURED;
@@ -611,7 +611,7 @@ static int dr_cpu_unconfigure(struct ds_info *dp,
611611

612612
printk(KERN_INFO "ds-%llu: Shutting down cpu %d...\n",
613613
dp->id, cpu);
614-
err = cpu_down(cpu);
614+
err = remove_cpu(cpu);
615615
if (err)
616616
dr_cpu_mark(resp, cpu, ncpus,
617617
DR_CPU_RES_FAILURE,

0 commit comments

Comments
 (0)