Skip to content

Commit 7fa043e

Browse files
committed
drm/i915: fix build with missing debugfs includes
/home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/i915_debugfs_params.c:213:9: error: call to undeclared function 'debugfs_create_file_unsafe'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] return debugfs_create_file_unsafe(name, mode, parent, value, ^ /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/i915_debugfs_params.c:213:9: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'struct dentry *' [-Wint-conversion] return debugfs_create_file_unsafe(name, mode, parent, value, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/i915_debugfs_params.c:222:9: error: call to undeclared function 'debugfs_create_file_unsafe'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] return debugfs_create_file_unsafe(name, mode, parent, value, ^ /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/i915_debugfs_params.c:222:9: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'struct dentry *' [-Wint-conversion] return debugfs_create_file_unsafe(name, mode, parent, value, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Building with clang gave me a bunch of similiar fails to the above. Fixes: 33d5ae6 ("drm/print: drop include debugfs.h and include where needed") Signed-off-by: Dave Airlie <[email protected]>
1 parent 90153b3 commit 7fa043e

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

drivers/gpu/drm/i915/i915_debugfs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#include <linux/sort.h>
3131
#include <linux/string_helpers.h>
3232

33+
#include <linux/debugfs.h>
3334
#include <drm/drm_debugfs.h>
3435

3536
#include "display/intel_display_params.h"

drivers/gpu/drm/i915/i915_debugfs_params.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55

66
#include <linux/kernel.h>
7+
#include <linux/debugfs.h>
78

89
#include "i915_debugfs_params.h"
910
#include "gt/intel_gt.h"

drivers/gpu/drm/i915/i915_gpu_error.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
*/
2929

3030
#include <linux/ascii85.h>
31+
#include <linux/debugfs.h>
3132
#include <linux/highmem.h>
3233
#include <linux/nmi.h>
3334
#include <linux/pagevec.h>

0 commit comments

Comments
 (0)