Skip to content

Commit 7ff8718

Browse files
GustavoARSilvatorvalds
authored andcommitted
gcov: gcc_3_4: replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Cc: Peter Oberparleiter <[email protected]> Link: http://lkml.kernel.org/r/20200302224501.GA14175@embeddedor Signed-off-by: Linus Torvalds <[email protected]>
1 parent fba4168 commit 7ff8718

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

kernel/gcov/gcc_3_4.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ static struct gcov_info *gcov_info_head;
3838
struct gcov_fn_info {
3939
unsigned int ident;
4040
unsigned int checksum;
41-
unsigned int n_ctrs[0];
41+
unsigned int n_ctrs[];
4242
};
4343

4444
/**
@@ -78,7 +78,7 @@ struct gcov_info {
7878
unsigned int n_functions;
7979
const struct gcov_fn_info *functions;
8080
unsigned int ctr_mask;
81-
struct gcov_ctr_info counts[0];
81+
struct gcov_ctr_info counts[];
8282
};
8383

8484
/**
@@ -352,7 +352,7 @@ struct gcov_iterator {
352352
unsigned int count;
353353

354354
int num_types;
355-
struct type_info type_info[0];
355+
struct type_info type_info[];
356356
};
357357

358358
static struct gcov_fn_info *get_func(struct gcov_iterator *iter)

0 commit comments

Comments
 (0)