Skip to content

Commit 8021414

Browse files
a3fWim Van Sebroeck
authored andcommitted
watchdog: f71808e_wdt: remove use of wrong watchdog_info option
The flags that should be or-ed into the watchdog_info.options by drivers all start with WDIOF_, e.g. WDIOF_SETTIMEOUT, which indicates that the driver's watchdog_ops has a usable set_timeout. WDIOC_SETTIMEOUT was used instead, which expands to 0xc0045706, which equals: WDIOF_FANFAULT | WDIOF_EXTERN1 | WDIOF_PRETIMEOUT | WDIOF_ALARMONLY | WDIOF_MAGICCLOSE | 0xc0045000 These were so far indicated to userspace on WDIOC_GETSUPPORT. As the driver has not yet been migrated to the new watchdog kernel API, the constant can just be dropped without substitute. Fixes: 96cb4eb ("watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E and F71882FG") Cc: [email protected] Signed-off-by: Ahmad Fatoum <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent e871e93 commit 8021414

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/watchdog/f71808e_wdt.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -690,8 +690,7 @@ static int __init watchdog_init(int sioaddr)
690690
* into the module have been registered yet.
691691
*/
692692
watchdog.sioaddr = sioaddr;
693-
watchdog.ident.options = WDIOC_SETTIMEOUT
694-
| WDIOF_MAGICCLOSE
693+
watchdog.ident.options = WDIOF_MAGICCLOSE
695694
| WDIOF_KEEPALIVEPING
696695
| WDIOF_CARDRESET;
697696

0 commit comments

Comments
 (0)