Skip to content

Commit 8046da4

Browse files
JustinStittkees
authored andcommitted
hwmon: (asus_wmi_sensors) Replace deprecated strncpy() with strscpy()
`strncpy` is deprecated for use on NUL-terminated destination strings [1]. We should prefer more robust and less ambiguous string interfaces. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer without unnecessarily NUL-padding. If, for any reason, NUL-padding is needed let's opt for `strscpy_pad`. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: KSPP#90 Cc: [email protected] Signed-off-by: Justin Stitt <[email protected]> Reviewed-by: Kees Cook <[email protected]> Link: https://lore.kernel.org/r/20230914-strncpy-drivers-hwmon-asus_wmi_sensors-c-v1-1-e1703cf91693@google.com Signed-off-by: Kees Cook <[email protected]>
1 parent 66f8a4a commit 8046da4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hwmon/asus_wmi_sensors.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ static int asus_wmi_sensor_info(int index, struct asus_wmi_sensor_info *s)
300300
goto out_free_obj;
301301
}
302302

303-
strncpy(s->name, name_obj.string.pointer, sizeof(s->name) - 1);
303+
strscpy(s->name, name_obj.string.pointer, sizeof(s->name));
304304

305305
data_type_obj = obj->package.elements[1];
306306
if (data_type_obj.type != ACPI_TYPE_INTEGER) {

0 commit comments

Comments
 (0)