Skip to content

Commit 8123437

Browse files
zainwangrockchipsmmind
authored andcommitted
arm64: dts: rockchip: Set RK3399-Gru PCLK_EDP to 24 MHz
We've found the AUX channel to be less reliable with PCLK_EDP at a higher rate (typically 25 MHz). This is especially important on systems with PSR-enabled panels (like Gru-Kevin), since we make heavy, constant use of AUX. According to Rockchip, using any rate other than 24 MHz can cause "problems between syncing the PHY an PCLK", which leads to all sorts of unreliabilities around register operations. Fixes: d67a38c ("arm64: dts: rockchip: move core edp from rk3399-kevin to shared chromebook") Reviewed-by: Douglas Anderson <[email protected]> Signed-off-by: zain wang <[email protected]> Signed-off-by: Brian Norris <[email protected]> Link: https://lore.kernel.org/r/20220830131212.v2.1.I98d30623f13b785ca77094d0c0fd4339550553b6@changeid Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 388f9f0 commit 8123437

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,14 @@
244244
&edp {
245245
status = "okay";
246246

247+
/*
248+
* eDP PHY/clk don't sync reliably at anything other than 24 MHz. Only
249+
* set this here, because rk3399-gru.dtsi ensures we can generate this
250+
* off GPLL=600MHz, whereas some other RK3399 boards may not.
251+
*/
252+
assigned-clocks = <&cru PCLK_EDP>;
253+
assigned-clock-rates = <24000000>;
254+
247255
ports {
248256
edp_out: port@1 {
249257
reg = <1>;

0 commit comments

Comments
 (0)