Skip to content

Commit 812e708

Browse files
committed
xtensa: use named assembly arguments in cmpxchg.h
Numeric assembly arguments are hard to understand and assembly code that uses them is hard to modify. Use named arguments in __cmpxchg_u32 and xchg_u32. Signed-off-by: Max Filippov <[email protected]>
1 parent 13e2813 commit 812e708

File tree

1 file changed

+35
-35
lines changed

1 file changed

+35
-35
lines changed

arch/xtensa/include/asm/cmpxchg.h

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -27,40 +27,40 @@ __cmpxchg_u32(volatile int *p, int old, int new)
2727
unsigned long tmp, result;
2828

2929
__asm__ __volatile__(
30-
"1: l32ex %0, %3\n"
31-
" bne %0, %4, 2f\n"
32-
" mov %1, %2\n"
33-
" s32ex %1, %3\n"
34-
" getex %1\n"
35-
" beqz %1, 1b\n"
30+
"1: l32ex %[result], %[addr]\n"
31+
" bne %[result], %[cmp], 2f\n"
32+
" mov %[tmp], %[new]\n"
33+
" s32ex %[tmp], %[addr]\n"
34+
" getex %[tmp]\n"
35+
" beqz %[tmp], 1b\n"
3636
"2:\n"
37-
: "=&a" (result), "=&a" (tmp)
38-
: "a" (new), "a" (p), "a" (old)
37+
: [result] "=&a" (result), [tmp] "=&a" (tmp)
38+
: [new] "a" (new), [addr] "a" (p), [cmp] "a" (old)
3939
: "memory"
4040
);
4141

4242
return result;
4343
#elif XCHAL_HAVE_S32C1I
4444
__asm__ __volatile__(
45-
" wsr %2, scompare1\n"
46-
" s32c1i %0, %1, 0\n"
47-
: "+a" (new)
48-
: "a" (p), "a" (old)
45+
" wsr %[cmp], scompare1\n"
46+
" s32c1i %[new], %[addr], 0\n"
47+
: [new] "+a" (new)
48+
: [addr] "a" (p), [cmp] "a" (old)
4949
: "memory"
5050
);
5151

5252
return new;
5353
#else
5454
__asm__ __volatile__(
5555
" rsil a15, "__stringify(TOPLEVEL)"\n"
56-
" l32i %0, %1, 0\n"
57-
" bne %0, %2, 1f\n"
58-
" s32i %3, %1, 0\n"
56+
" l32i %[old], %[addr], 0\n"
57+
" bne %[old], %[cmp], 1f\n"
58+
" s32i %[new], %[addr], 0\n"
5959
"1:\n"
6060
" wsr a15, ps\n"
6161
" rsync\n"
62-
: "=&a" (old)
63-
: "a" (p), "a" (old), "r" (new)
62+
: [old] "=&a" (old)
63+
: [addr] "a" (p), [cmp] "a" (old), [new] "r" (new)
6464
: "a15", "memory");
6565
return old;
6666
#endif
@@ -129,40 +129,40 @@ static inline unsigned long xchg_u32(volatile int * m, unsigned long val)
129129
unsigned long tmp, result;
130130

131131
__asm__ __volatile__(
132-
"1: l32ex %0, %3\n"
133-
" mov %1, %2\n"
134-
" s32ex %1, %3\n"
135-
" getex %1\n"
136-
" beqz %1, 1b\n"
137-
: "=&a" (result), "=&a" (tmp)
138-
: "a" (val), "a" (m)
132+
"1: l32ex %[result], %[addr]\n"
133+
" mov %[tmp], %[val]\n"
134+
" s32ex %[tmp], %[addr]\n"
135+
" getex %[tmp]\n"
136+
" beqz %[tmp], 1b\n"
137+
: [result] "=&a" (result), [tmp] "=&a" (tmp)
138+
: [val] "a" (val), [addr] "a" (m)
139139
: "memory"
140140
);
141141

142142
return result;
143143
#elif XCHAL_HAVE_S32C1I
144144
unsigned long tmp, result;
145145
__asm__ __volatile__(
146-
"1: l32i %1, %2, 0\n"
147-
" mov %0, %3\n"
148-
" wsr %1, scompare1\n"
149-
" s32c1i %0, %2, 0\n"
150-
" bne %0, %1, 1b\n"
151-
: "=&a" (result), "=&a" (tmp)
152-
: "a" (m), "a" (val)
146+
"1: l32i %[tmp], %[addr], 0\n"
147+
" mov %[result], %[val]\n"
148+
" wsr %[tmp], scompare1\n"
149+
" s32c1i %[result], %[addr], 0\n"
150+
" bne %[result], %[tmp], 1b\n"
151+
: [result] "=&a" (result), [tmp] "=&a" (tmp)
152+
: [addr] "a" (m), [val] "a" (val)
153153
: "memory"
154154
);
155155
return result;
156156
#else
157157
unsigned long tmp;
158158
__asm__ __volatile__(
159159
" rsil a15, "__stringify(TOPLEVEL)"\n"
160-
" l32i %0, %1, 0\n"
161-
" s32i %2, %1, 0\n"
160+
" l32i %[tmp], %[addr], 0\n"
161+
" s32i %[val], %[addr], 0\n"
162162
" wsr a15, ps\n"
163163
" rsync\n"
164-
: "=&a" (tmp)
165-
: "a" (m), "a" (val)
164+
: [tmp] "=&a" (tmp)
165+
: [addr] "a" (m), [val] "a" (val)
166166
: "a15", "memory");
167167
return tmp;
168168
#endif

0 commit comments

Comments
 (0)