Skip to content

Commit 8130b05

Browse files
vingu-linarorafaeljw
authored andcommitted
PM: EM: fix wrong utilization estimation in em_cpu_energy()
Commit 1b600da ("PM: EM: Optimize em_cpu_energy() and remove division") has added back map_util_perf() in em_cpu_energy() computation which has been removed with the rework of scheduler/cpufreq interface. This is wrong because sugov_effective_cpu_perf() already takes care of mapping the utilization to a performance level. Fixes: 1b600da ("PM: EM: Optimize em_cpu_energy() and remove division") Signed-off-by: Vincent Guittot <[email protected]> Reviewed-by: Lukasz Luba <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 39cd87c commit 8130b05

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

include/linux/energy_model.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
245245
* max utilization to the allowed CPU capacity before calculating
246246
* effective performance.
247247
*/
248-
max_util = map_util_perf(max_util);
249248
max_util = min(max_util, allowed_cpu_cap);
250249

251250
/*

0 commit comments

Comments
 (0)