Skip to content

Commit 816df94

Browse files
Marco FelschpH5
authored andcommitted
drm/imx: drop useless best_encoder callback
The best_encoder() callback is used by the drm-core to find an encoder if the connector is connected to multiple encoders but the parallel, tve and ldb uses always the 1-encoder : 1-connector setup. Such a simple setup can be handled by the drm-core. Signed-off-by: Marco Felsch <[email protected]> Reviewed-by: Philipp Zabel <[email protected]> Signed-off-by: Philipp Zabel <[email protected]>
1 parent 7bb58b9 commit 816df94

File tree

3 files changed

+0
-27
lines changed

3 files changed

+0
-27
lines changed

drivers/gpu/drm/imx/imx-ldb.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,14 +156,6 @@ static int imx_ldb_connector_get_modes(struct drm_connector *connector)
156156
return num_modes;
157157
}
158158

159-
static struct drm_encoder *imx_ldb_connector_best_encoder(
160-
struct drm_connector *connector)
161-
{
162-
struct imx_ldb_channel *imx_ldb_ch = con_to_imx_ldb_ch(connector);
163-
164-
return &imx_ldb_ch->encoder;
165-
}
166-
167159
static void imx_ldb_set_clock(struct imx_ldb *ldb, int mux, int chno,
168160
unsigned long serial_clk, unsigned long di_clk)
169161
{
@@ -391,7 +383,6 @@ static const struct drm_connector_funcs imx_ldb_connector_funcs = {
391383

392384
static const struct drm_connector_helper_funcs imx_ldb_connector_helper_funcs = {
393385
.get_modes = imx_ldb_connector_get_modes,
394-
.best_encoder = imx_ldb_connector_best_encoder,
395386
};
396387

397388
static const struct drm_encoder_helper_funcs imx_ldb_encoder_helper_funcs = {

drivers/gpu/drm/imx/imx-tve.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -260,14 +260,6 @@ static int imx_tve_connector_mode_valid(struct drm_connector *connector,
260260
return MODE_BAD;
261261
}
262262

263-
static struct drm_encoder *imx_tve_connector_best_encoder(
264-
struct drm_connector *connector)
265-
{
266-
struct imx_tve *tve = con_to_tve(connector);
267-
268-
return &tve->encoder;
269-
}
270-
271263
static void imx_tve_encoder_mode_set(struct drm_encoder *encoder,
272264
struct drm_display_mode *orig_mode,
273265
struct drm_display_mode *mode)
@@ -345,7 +337,6 @@ static const struct drm_connector_funcs imx_tve_connector_funcs = {
345337

346338
static const struct drm_connector_helper_funcs imx_tve_connector_helper_funcs = {
347339
.get_modes = imx_tve_connector_get_modes,
348-
.best_encoder = imx_tve_connector_best_encoder,
349340
.mode_valid = imx_tve_connector_mode_valid,
350341
};
351342

drivers/gpu/drm/imx/parallel-display.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,6 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
8888
return num_modes;
8989
}
9090

91-
static struct drm_encoder *imx_pd_connector_best_encoder(
92-
struct drm_connector *connector)
93-
{
94-
struct imx_parallel_display *imxpd = con_to_imxpd(connector);
95-
96-
return &imxpd->encoder;
97-
}
98-
9991
static void imx_pd_bridge_enable(struct drm_bridge *bridge)
10092
{
10193
struct imx_parallel_display *imxpd = bridge_to_imxpd(bridge);
@@ -254,7 +246,6 @@ static const struct drm_connector_funcs imx_pd_connector_funcs = {
254246

255247
static const struct drm_connector_helper_funcs imx_pd_connector_helper_funcs = {
256248
.get_modes = imx_pd_connector_get_modes,
257-
.best_encoder = imx_pd_connector_best_encoder,
258249
};
259250

260251
static const struct drm_bridge_funcs imx_pd_bridge_funcs = {

0 commit comments

Comments
 (0)