Skip to content

Commit 820545b

Browse files
committed
KVM: x86: Shuffle code to prepare for dropping guest_cpuid_has()
Move the implementations of guest_has_{spec_ctrl,pred_cmd}_msr() down below guest_cpu_cap_has() so that their use of guest_cpuid_has() can be replaced with calls to guest_cpu_cap_has(). No functional change intended. Reviewed-by: Maxim Levitsky <[email protected]> Reviewed-by: Binbin Wu <[email protected]> Reviewed-by: Xiaoyao Li <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sean Christopherson <[email protected]>
1 parent 75d4642 commit 820545b

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

arch/x86/kvm/cpuid.h

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -150,21 +150,6 @@ static inline int guest_cpuid_stepping(struct kvm_vcpu *vcpu)
150150
return x86_stepping(best->eax);
151151
}
152152

153-
static inline bool guest_has_spec_ctrl_msr(struct kvm_vcpu *vcpu)
154-
{
155-
return (guest_cpuid_has(vcpu, X86_FEATURE_SPEC_CTRL) ||
156-
guest_cpuid_has(vcpu, X86_FEATURE_AMD_STIBP) ||
157-
guest_cpuid_has(vcpu, X86_FEATURE_AMD_IBRS) ||
158-
guest_cpuid_has(vcpu, X86_FEATURE_AMD_SSBD));
159-
}
160-
161-
static inline bool guest_has_pred_cmd_msr(struct kvm_vcpu *vcpu)
162-
{
163-
return (guest_cpuid_has(vcpu, X86_FEATURE_SPEC_CTRL) ||
164-
guest_cpuid_has(vcpu, X86_FEATURE_AMD_IBPB) ||
165-
guest_cpuid_has(vcpu, X86_FEATURE_SBPB));
166-
}
167-
168153
static inline bool supports_cpuid_fault(struct kvm_vcpu *vcpu)
169154
{
170155
return vcpu->arch.msr_platform_info & MSR_PLATFORM_INFO_CPUID_FAULT;
@@ -280,4 +265,19 @@ static inline bool kvm_vcpu_is_legal_cr3(struct kvm_vcpu *vcpu, unsigned long cr
280265
return kvm_vcpu_is_legal_gpa(vcpu, cr3);
281266
}
282267

268+
static inline bool guest_has_spec_ctrl_msr(struct kvm_vcpu *vcpu)
269+
{
270+
return (guest_cpuid_has(vcpu, X86_FEATURE_SPEC_CTRL) ||
271+
guest_cpuid_has(vcpu, X86_FEATURE_AMD_STIBP) ||
272+
guest_cpuid_has(vcpu, X86_FEATURE_AMD_IBRS) ||
273+
guest_cpuid_has(vcpu, X86_FEATURE_AMD_SSBD));
274+
}
275+
276+
static inline bool guest_has_pred_cmd_msr(struct kvm_vcpu *vcpu)
277+
{
278+
return (guest_cpuid_has(vcpu, X86_FEATURE_SPEC_CTRL) ||
279+
guest_cpuid_has(vcpu, X86_FEATURE_AMD_IBPB) ||
280+
guest_cpuid_has(vcpu, X86_FEATURE_SBPB));
281+
}
282+
283283
#endif

0 commit comments

Comments
 (0)