Skip to content

Commit 820e690

Browse files
committed
Merge tag 'drm-misc-next-fixes-2022-01-14' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
* atomic helpers: Fix error messages * mipi-dbi: Fix buffer mapping Signed-off-by: Daniel Vetter <[email protected]> From: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/YeGHu7qU92pjuQOn@linux-uq9g
2 parents 71e4a70 + 5d474cc commit 820e690

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -828,8 +828,8 @@ int drm_atomic_helper_check_plane_state(struct drm_plane_state *plane_state,
828828
}
829829

830830
if (!crtc_state->enable && !can_update_disabled) {
831-
drm_dbg_kms(plane_state->crtc->dev,
832-
"Cannot update plane of a disabled CRTC.\n");
831+
drm_dbg_kms(plane_state->plane->dev,
832+
"Cannot update plane of a disabled CRTC.\n");
833833
return -EINVAL;
834834
}
835835

@@ -839,8 +839,8 @@ int drm_atomic_helper_check_plane_state(struct drm_plane_state *plane_state,
839839
hscale = drm_rect_calc_hscale(src, dst, min_scale, max_scale);
840840
vscale = drm_rect_calc_vscale(src, dst, min_scale, max_scale);
841841
if (hscale < 0 || vscale < 0) {
842-
drm_dbg_kms(plane_state->crtc->dev,
843-
"Invalid scaling of plane\n");
842+
drm_dbg_kms(plane_state->plane->dev,
843+
"Invalid scaling of plane\n");
844844
drm_rect_debug_print("src: ", &plane_state->src, true);
845845
drm_rect_debug_print("dst: ", &plane_state->dst, false);
846846
return -ERANGE;
@@ -864,8 +864,8 @@ int drm_atomic_helper_check_plane_state(struct drm_plane_state *plane_state,
864864
return 0;
865865

866866
if (!can_position && !drm_rect_equals(dst, &clip)) {
867-
drm_dbg_kms(plane_state->crtc->dev,
868-
"Plane must cover entire CRTC\n");
867+
drm_dbg_kms(plane_state->plane->dev,
868+
"Plane must cover entire CRTC\n");
869869
drm_rect_debug_print("dst: ", dst, false);
870870
drm_rect_debug_print("clip: ", &clip, false);
871871
return -EINVAL;

drivers/gpu/drm/drm_mipi_dbi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,11 @@ int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb,
209209
ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
210210
if (ret)
211211
return ret;
212-
src = data[0].vaddr; /* TODO: Use mapping abstraction properly */
213212

214213
ret = drm_gem_fb_vmap(fb, map, data);
215214
if (ret)
216215
goto out_drm_gem_fb_end_cpu_access;
216+
src = data[0].vaddr; /* TODO: Use mapping abstraction properly */
217217

218218
switch (fb->format->format) {
219219
case DRM_FORMAT_RGB565:

0 commit comments

Comments
 (0)