Skip to content

Commit 823f209

Browse files
sj-awsbostrovs
authored andcommitted
xen/blkback: Remove unnecessary static variable name prefixes
A few of static variables in blkback have 'xen_blkif_' prefix, though it is unnecessary for static variables. This commit removes such prefixes. Reviewed-by: Roger Pau Monné <[email protected]> Signed-off-by: SeongJae Park <[email protected]> Signed-off-by: Boris Ostrovsky <[email protected]>
1 parent cb9369b commit 823f209

File tree

1 file changed

+17
-20
lines changed

1 file changed

+17
-20
lines changed

drivers/block/xen-blkback/blkback.c

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@
6262
* IO workloads.
6363
*/
6464

65-
static int xen_blkif_max_buffer_pages = 1024;
66-
module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, 0644);
65+
static int max_buffer_pages = 1024;
66+
module_param_named(max_buffer_pages, max_buffer_pages, int, 0644);
6767
MODULE_PARM_DESC(max_buffer_pages,
6868
"Maximum number of free pages to keep in each block backend buffer");
6969

@@ -78,8 +78,8 @@ MODULE_PARM_DESC(max_buffer_pages,
7878
* algorithm.
7979
*/
8080

81-
static int xen_blkif_max_pgrants = 1056;
82-
module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, 0644);
81+
static int max_pgrants = 1056;
82+
module_param_named(max_persistent_grants, max_pgrants, int, 0644);
8383
MODULE_PARM_DESC(max_persistent_grants,
8484
"Maximum number of grants to map persistently");
8585

@@ -88,8 +88,8 @@ MODULE_PARM_DESC(max_persistent_grants,
8888
* use. The time is in seconds, 0 means indefinitely long.
8989
*/
9090

91-
static unsigned int xen_blkif_pgrant_timeout = 60;
92-
module_param_named(persistent_grant_unused_seconds, xen_blkif_pgrant_timeout,
91+
static unsigned int pgrant_timeout = 60;
92+
module_param_named(persistent_grant_unused_seconds, pgrant_timeout,
9393
uint, 0644);
9494
MODULE_PARM_DESC(persistent_grant_unused_seconds,
9595
"Time in seconds an unused persistent grant is allowed to "
@@ -137,9 +137,8 @@ module_param(log_stats, int, 0644);
137137

138138
static inline bool persistent_gnt_timeout(struct persistent_gnt *persistent_gnt)
139139
{
140-
return xen_blkif_pgrant_timeout &&
141-
(jiffies - persistent_gnt->last_used >=
142-
HZ * xen_blkif_pgrant_timeout);
140+
return pgrant_timeout && (jiffies - persistent_gnt->last_used >=
141+
HZ * pgrant_timeout);
143142
}
144143

145144
static inline int get_free_page(struct xen_blkif_ring *ring, struct page **page)
@@ -234,7 +233,7 @@ static int add_persistent_gnt(struct xen_blkif_ring *ring,
234233
struct persistent_gnt *this;
235234
struct xen_blkif *blkif = ring->blkif;
236235

237-
if (ring->persistent_gnt_c >= xen_blkif_max_pgrants) {
236+
if (ring->persistent_gnt_c >= max_pgrants) {
238237
if (!blkif->vbd.overflow_max_grants)
239238
blkif->vbd.overflow_max_grants = 1;
240239
return -EBUSY;
@@ -397,14 +396,13 @@ static void purge_persistent_gnt(struct xen_blkif_ring *ring)
397396
goto out;
398397
}
399398

400-
if (ring->persistent_gnt_c < xen_blkif_max_pgrants ||
401-
(ring->persistent_gnt_c == xen_blkif_max_pgrants &&
399+
if (ring->persistent_gnt_c < max_pgrants ||
400+
(ring->persistent_gnt_c == max_pgrants &&
402401
!ring->blkif->vbd.overflow_max_grants)) {
403402
num_clean = 0;
404403
} else {
405-
num_clean = (xen_blkif_max_pgrants / 100) * LRU_PERCENT_CLEAN;
406-
num_clean = ring->persistent_gnt_c - xen_blkif_max_pgrants +
407-
num_clean;
404+
num_clean = (max_pgrants / 100) * LRU_PERCENT_CLEAN;
405+
num_clean = ring->persistent_gnt_c - max_pgrants + num_clean;
408406
num_clean = min(ring->persistent_gnt_c, num_clean);
409407
pr_debug("Going to purge at least %u persistent grants\n",
410408
num_clean);
@@ -599,8 +597,7 @@ static void print_stats(struct xen_blkif_ring *ring)
599597
current->comm, ring->st_oo_req,
600598
ring->st_rd_req, ring->st_wr_req,
601599
ring->st_f_req, ring->st_ds_req,
602-
ring->persistent_gnt_c,
603-
xen_blkif_max_pgrants);
600+
ring->persistent_gnt_c, max_pgrants);
604601
ring->st_print = jiffies + msecs_to_jiffies(10 * 1000);
605602
ring->st_rd_req = 0;
606603
ring->st_wr_req = 0;
@@ -660,7 +657,7 @@ int xen_blkif_schedule(void *arg)
660657
if (time_before(jiffies, blkif->buffer_squeeze_end))
661658
shrink_free_pagepool(ring, 0);
662659
else
663-
shrink_free_pagepool(ring, xen_blkif_max_buffer_pages);
660+
shrink_free_pagepool(ring, max_buffer_pages);
664661

665662
if (log_stats && time_after(jiffies, ring->st_print))
666663
print_stats(ring);
@@ -887,7 +884,7 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring,
887884
continue;
888885
}
889886
if (use_persistent_gnts &&
890-
ring->persistent_gnt_c < xen_blkif_max_pgrants) {
887+
ring->persistent_gnt_c < max_pgrants) {
891888
/*
892889
* We are using persistent grants, the grant is
893890
* not mapped but we might have room for it.
@@ -914,7 +911,7 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring,
914911
pages[seg_idx]->persistent_gnt = persistent_gnt;
915912
pr_debug("grant %u added to the tree of persistent grants, using %u/%u\n",
916913
persistent_gnt->gnt, ring->persistent_gnt_c,
917-
xen_blkif_max_pgrants);
914+
max_pgrants);
918915
goto next;
919916
}
920917
if (use_persistent_gnts && !blkif->vbd.overflow_max_grants) {

0 commit comments

Comments
 (0)