Skip to content

Commit 82e16f8

Browse files
Ondrej ZaryDamien Le Moal
authored andcommitted
ata: pata_parport-bpck6: move ppc6_deselect to bpck6.c and rename
Move ppc6_deselect to bpck6.c and rename it to bpck6_deselect Signed-off-by: Ondrej Zary <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent cad40b2 commit 82e16f8

File tree

2 files changed

+17
-21
lines changed

2 files changed

+17
-21
lines changed

drivers/ata/pata_parport/bpck6.c

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,21 @@ static int bpck6_open(struct pi_adapter *pi)
235235
return 0; // FAIL
236236
}
237237

238+
static void bpck6_deselect(struct pi_adapter *pi)
239+
{
240+
if (mode_map[pi->mode] & 4) // EPP
241+
parport_frob_control(pi->pardev->port, PARPORT_CONTROL_INIT,
242+
PARPORT_CONTROL_INIT);
243+
else // PPC/ECP
244+
parport_frob_control(pi->pardev->port, PARPORT_CONTROL_SELECT,
245+
PARPORT_CONTROL_SELECT);
246+
247+
parport_write_data(pi->pardev->port, pi->saved_r0);
248+
parport_write_control(pi->pardev->port,
249+
pi->saved_r2 | PARPORT_CONTROL_SELECT);
250+
parport_write_control(pi->pardev->port, pi->saved_r2);
251+
}
252+
238253
static void bpck6_wr_extout(struct pi_adapter *pi, u8 regdata)
239254
{
240255
ppc6_send_cmd(pi, REG_VERSION | ACCESS_REG | ACCESS_WRITE);
@@ -253,7 +268,7 @@ static void bpck6_disconnect(struct pi_adapter *pi)
253268
{
254269
dev_dbg(&pi->dev, "disconnect\n");
255270
bpck6_wr_extout(pi, 0x0);
256-
ppc6_deselect(pi);
271+
bpck6_deselect(pi);
257272
}
258273

259274
static int bpck6_test_port(struct pi_adapter *pi) /* check for 8-bit port */
@@ -285,7 +300,7 @@ static int bpck6_probe_unit(struct pi_adapter *pi)
285300

286301
if(out)
287302
{
288-
ppc6_deselect(pi);
303+
bpck6_deselect(pi);
289304
dev_dbg(&pi->dev, "leaving probe\n");
290305
pi->mode = saved_mode;
291306
return(1);

drivers/ata/pata_parport/ppc6lnx.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767

6868
//***************************************************************************
6969

70-
static void ppc6_deselect(struct pi_adapter *pi);
7170
static void ppc6_send_cmd(struct pi_adapter *pi, u8 cmd);
7271
static void ppc6_wr_data_byte(struct pi_adapter *pi, u8 data);
7372
static u8 ppc6_rd_data_byte(struct pi_adapter *pi);
@@ -79,24 +78,6 @@ int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
7978

8079
//***************************************************************************
8180

82-
static void ppc6_deselect(struct pi_adapter *pi)
83-
{
84-
if (mode_map[pi->mode] & 4) // EPP
85-
parport_frob_control(pi->pardev->port,
86-
PARPORT_CONTROL_INIT, PARPORT_CONTROL_INIT);
87-
else // PPC/ECP
88-
parport_frob_control(pi->pardev->port,
89-
PARPORT_CONTROL_SELECT, PARPORT_CONTROL_SELECT);
90-
91-
parport_write_data(pi->pardev->port, pi->saved_r0);
92-
93-
parport_write_control(pi->pardev->port, (pi->saved_r2 | PARPORT_CONTROL_SELECT));
94-
95-
parport_write_control(pi->pardev->port, pi->saved_r2);
96-
}
97-
98-
//***************************************************************************
99-
10081
static void ppc6_send_cmd(struct pi_adapter *pi, u8 cmd)
10182
{
10283
switch (mode_map[pi->mode])

0 commit comments

Comments
 (0)