Skip to content

Commit 82e33f2

Browse files
Mirsad Todorovacakpm00
authored andcommitted
fs/proc/kcore.c: fix coccinelle reported ERROR instances
Coccinelle complains about the nested reuse of the pointer `iter' with different pointer type: ./fs/proc/kcore.c:515:26-30: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:534:23-27: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:550:40-44: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:568:27-31: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:581:28-32: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:599:27-31: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:607:38-42: ERROR: invalid reference to the index variable of the iterator on line 499 ./fs/proc/kcore.c:614:26-30: ERROR: invalid reference to the index variable of the iterator on line 499 Replacing `struct kcore_list *iter' with `struct kcore_list *tmp' doesn't change the scope and the functionality is the same and coccinelle seems happy. NOTE: There was an issue with using `struct kcore_list *pos' as the nested iterator. The build did not work! [[email protected]: s/tmp/pos/] Link: https://lkml.kernel.org/r/[email protected] Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1] Link: https://lkml.kernel.org/r/[email protected] Fixes: 04d168c ("fs/proc/kcore.c: remove check of list iterator against head past the loop body") Signed-off-by: Jakob Koschel <[email protected]> Signed-off-by: Mirsad Todorovac <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: Oscar Salvador <[email protected]> Cc: "Brian Johannesmeyer" <[email protected]> Cc: Cristiano Giuffrida <[email protected]> Cc: "Bos, H.J." <[email protected]> Cc: Alexey Dobriyan <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Yang Li <[email protected]> Cc: Baoquan He <[email protected]> Cc: Hari Bathini <[email protected]> Cc: Yan Zhen <[email protected]> Cc: Alexander Gordeev <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent d7ce9c7 commit 82e33f2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

fs/proc/kcore.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -493,13 +493,13 @@ static ssize_t read_kcore_iter(struct kiocb *iocb, struct iov_iter *iter)
493493
* the previous entry, search for a matching entry.
494494
*/
495495
if (!m || start < m->addr || start >= m->addr + m->size) {
496-
struct kcore_list *iter;
496+
struct kcore_list *pos;
497497

498498
m = NULL;
499-
list_for_each_entry(iter, &kclist_head, list) {
500-
if (start >= iter->addr &&
501-
start < iter->addr + iter->size) {
502-
m = iter;
499+
list_for_each_entry(pos, &kclist_head, list) {
500+
if (start >= pos->addr &&
501+
start < pos->addr + pos->size) {
502+
m = pos;
503503
break;
504504
}
505505
}

0 commit comments

Comments
 (0)