Skip to content

Commit 835443d

Browse files
sberbzAndi Shyti
authored andcommitted
drm/i915/gt: Log reason for setting TAINT_WARN at reset
TAINT_WARN is used to notify CI about non-recoverable failures, which require device to be restarted. In some cases, there is no sufficient information about the reason for the restart. The test runner is just killed, and DUT is rebooted, logging only 'probe with driver i915 failed with error -4' to dmesg. Printing error to dmesg before TAINT_WARN, would explain why the device has been restarted, and what caused the malfunction in the first place. Signed-off-by: Sebastian Brzezinka <[email protected]> Reviewed-by: Andi Shyti <[email protected]> Signed-off-by: Andi Shyti <[email protected]> Acked-by: Rodrigo Vivi <[email protected]> Signed-off-by: Andi Shyti <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 5ed539e commit 835443d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/gpu/drm/i915/gt/intel_reset.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1113,6 +1113,7 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt)
11131113
* Warn CI about the unrecoverable wedged condition.
11141114
* Time for a reboot.
11151115
*/
1116+
gt_err(gt, "Unrecoverable wedged condition\n");
11161117
add_taint_for_CI(gt->i915, TAINT_WARN);
11171118
return false;
11181119
}
@@ -1263,8 +1264,10 @@ void intel_gt_reset(struct intel_gt *gt,
12631264
}
12641265

12651266
ret = resume(gt);
1266-
if (ret)
1267+
if (ret) {
1268+
gt_err(gt, "Failed to resume (%d)\n", ret);
12671269
goto taint;
1270+
}
12681271

12691272
finish:
12701273
reset_finish(gt, awake);
@@ -1607,6 +1610,7 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt)
16071610
set_bit(I915_WEDGED_ON_INIT, &gt->reset.flags);
16081611

16091612
/* Wedged on init is non-recoverable */
1613+
gt_err(gt, "Non-recoverable wedged on init\n");
16101614
add_taint_for_CI(gt->i915, TAINT_WARN);
16111615
}
16121616

0 commit comments

Comments
 (0)