Skip to content

Commit 83714dc

Browse files
Kalesh APkuba-moo
authored andcommitted
bnxt_en: Fix reporting of test result in ethtool selftest
When the selftest command fails, driver is not reporting the failure by updating the "test->flags" when bnxt_close_nic() fails. Fixes: eb51365 ("bnxt_en: Add basic ethtool -t selftest support.") Reviewed-by: Pavan Chebbi <[email protected]> Reviewed-by: Somnath Kotur <[email protected]> Signed-off-by: Kalesh AP <[email protected]> Signed-off-by: Michael Chan <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c5cff16 commit 83714dc

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3738,6 +3738,7 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest,
37383738
bnxt_ulp_stop(bp);
37393739
rc = bnxt_close_nic(bp, true, false);
37403740
if (rc) {
3741+
etest->flags |= ETH_TEST_FL_FAILED;
37413742
bnxt_ulp_start(bp, rc);
37423743
return;
37433744
}

0 commit comments

Comments
 (0)