Skip to content

Commit 837d7a8

Browse files
author
Marc Zyngier
committed
h8300: Fix linux/irqchip.h include mess
h8300 drags linux/irqchip.h from asm/irq.h, which is in general a bad idea (asm/*.h should avoid dragging linux/*.h, as it is usually supposed to work the other way around). Move the inclusion of linux/irqchip.h to the single location where it actually matters in the arch code. Reported-by: Guenter Roeck <[email protected]> Tested-by: Guenter Roeck <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent d2cf863 commit 837d7a8

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

arch/h8300/include/asm/irq.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
#ifndef _H8300_IRQ_H_
33
#define _H8300_IRQ_H_
44

5-
#include <linux/irqchip.h>
6-
75
#if defined(CONFIG_CPU_H8300H)
86
#define NR_IRQS 64
97
#define IRQ_CHIP h8300h_irq_chip

arch/h8300/kernel/irq.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <linux/init.h>
99
#include <linux/interrupt.h>
1010
#include <linux/irq.h>
11+
#include <linux/irqchip.h>
1112
#include <linux/irqdomain.h>
1213
#include <linux/of_irq.h>
1314
#include <asm/traps.h>

0 commit comments

Comments
 (0)