Skip to content

Commit 83d0010

Browse files
committed
Merge branch 'QorIQ-DPAA-ARM-RDBs-need-internal-delay-on-RGMII'
Madalin Bucur says: ==================== QorIQ DPAA ARM RDBs need internal delay on RGMII v2: used phy_interface_mode_is_rgmii() to identify RGMII The QorIQ DPAA 1 based RDB boards require internal delay on both Tx and Rx to be set. The patch set ensures all RGMII modes are treated correctly by the FMan driver and sets the phy-connection-type to "rgmii-id" to restore functionality. Previously Rx internal delay was set by board pull-ups and was left untouched by the PHY driver. Since commit 1b3047b ("net: phy: realtek: add support for configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver has control over the RGMII RX delay and it is disabling it for other modes than RGMII_RXID and RGMII_ID. Please note that u-boot in particular performs a fix-up of the PHY connection type and will overwrite the values from the Linux device tree. Another patch set was sent for u-boot and one needs to apply that [1] to the boot loader, to ensure this fix is complete, unless a different bootloader is used. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 23c3948 + d79e9d7 commit 83d0010

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,12 @@
119119

120120
ethernet@e4000 {
121121
phy-handle = <&rgmii_phy1>;
122-
phy-connection-type = "rgmii-txid";
122+
phy-connection-type = "rgmii-id";
123123
};
124124

125125
ethernet@e6000 {
126126
phy-handle = <&rgmii_phy2>;
127-
phy-connection-type = "rgmii-txid";
127+
phy-connection-type = "rgmii-id";
128128
};
129129

130130
ethernet@e8000 {

arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,12 @@
131131
&fman0 {
132132
ethernet@e4000 {
133133
phy-handle = <&rgmii_phy1>;
134-
phy-connection-type = "rgmii";
134+
phy-connection-type = "rgmii-id";
135135
};
136136

137137
ethernet@e6000 {
138138
phy-handle = <&rgmii_phy2>;
139-
phy-connection-type = "rgmii";
139+
phy-connection-type = "rgmii-id";
140140
};
141141

142142
ethernet@e8000 {

drivers/net/ethernet/freescale/fman/fman_memac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ int memac_adjust_link(struct fman_mac *memac, u16 speed)
782782
/* Set full duplex */
783783
tmp &= ~IF_MODE_HD;
784784

785-
if (memac->phy_if == PHY_INTERFACE_MODE_RGMII) {
785+
if (phy_interface_mode_is_rgmii(memac->phy_if)) {
786786
/* Configure RGMII in manual mode */
787787
tmp &= ~IF_MODE_RGMII_AUTO;
788788
tmp &= ~IF_MODE_RGMII_SP_MASK;

0 commit comments

Comments
 (0)