Skip to content

Commit 840a97e

Browse files
author
Bartosz Golaszewski
committed
gpio: sim: delimit the fwnode name with a ":" when generating labels
Typically, whenever a human-readable name is created for objects using a software node, its name is delimited with ":" as dashes are often used in other parts of the name. Make gpio-sim use the same pattern. This results in better looking default names: gpio-sim.0:node0 gpio-sim.0:node1 gpio-sim.1:node0 Signed-off-by: Bartosz Golaszewski <[email protected]> Acked-by: Linus Walleij <[email protected]>
1 parent 11498d9 commit 840a97e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpio/gpio-sim.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
421421

422422
ret = fwnode_property_read_string(swnode, "gpio-sim,label", &label);
423423
if (ret) {
424-
label = devm_kasprintf(dev, GFP_KERNEL, "%s-%pfwP",
424+
label = devm_kasprintf(dev, GFP_KERNEL, "%s:%pfwP",
425425
dev_name(dev), swnode);
426426
if (!label)
427427
return -ENOMEM;
@@ -836,7 +836,7 @@ static int gpio_sim_add_hogs(struct gpio_sim_device *dev)
836836
GFP_KERNEL);
837837
else
838838
hog->chip_label = kasprintf(GFP_KERNEL,
839-
"gpio-sim.%u-%pfwP",
839+
"gpio-sim.%u:%pfwP",
840840
dev->id,
841841
bank->swnode);
842842
if (!hog->chip_label) {

0 commit comments

Comments
 (0)