Skip to content

Commit 8475a1d

Browse files
rfvirgiltiwai
authored andcommitted
ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control_remove()
The driver doesn't create any ALSA controls for firmware controls, so it shouldn't be calling hda_cs_dsp_control_remove(). commit 312c04c ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients") removed the call to hda_cs_dsp_add_controls() but didn't remove the call for destroying those controls. Signed-off-by: Richard Fitzgerald <[email protected]> Fixes: 312c04c ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients") Link: https://patch.msgid.link/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 12d82c7 commit 8475a1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/pci/hda/cs35l41_hda.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ static const struct reg_sequence cs35l41_hda_mute[] = {
134134
};
135135

136136
static const struct cs_dsp_client_ops client_ops = {
137-
.control_remove = hda_cs_dsp_control_remove,
137+
/* cs_dsp requires the client to provide this even if it is empty */
138138
};
139139

140140
static int cs35l41_request_tuning_param_file(struct cs35l41_hda *cs35l41, char *tuning_filename,

0 commit comments

Comments
 (0)