Skip to content

Commit 84bd06c

Browse files
Christoph Hellwigaxboe
authored andcommitted
iov_iter: remove iov_iter_get_pages and iov_iter_get_pages_alloc
Now that the direct I/O helpers have switched to use iov_iter_extract_pages, these helpers are unused. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Christian Brauner <[email protected]> Reviewed-by: David Howells <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent e4cc646 commit 84bd06c

File tree

2 files changed

+7
-34
lines changed

2 files changed

+7
-34
lines changed

include/linux/uio.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -277,14 +277,8 @@ void iov_iter_bvec(struct iov_iter *i, unsigned int direction, const struct bio_
277277
void iov_iter_discard(struct iov_iter *i, unsigned int direction, size_t count);
278278
void iov_iter_xarray(struct iov_iter *i, unsigned int direction, struct xarray *xarray,
279279
loff_t start, size_t count);
280-
ssize_t iov_iter_get_pages(struct iov_iter *i, struct page **pages,
281-
size_t maxsize, unsigned maxpages, size_t *start,
282-
iov_iter_extraction_t extraction_flags);
283280
ssize_t iov_iter_get_pages2(struct iov_iter *i, struct page **pages,
284281
size_t maxsize, unsigned maxpages, size_t *start);
285-
ssize_t iov_iter_get_pages_alloc(struct iov_iter *i,
286-
struct page ***pages, size_t maxsize, size_t *start,
287-
iov_iter_extraction_t extraction_flags);
288282
ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i, struct page ***pages,
289283
size_t maxsize, size_t *start);
290284
int iov_iter_npages(const struct iov_iter *i, int maxpages);

lib/iov_iter.c

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,8 +1082,7 @@ static struct page *first_bvec_segment(const struct iov_iter *i,
10821082

10831083
static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i,
10841084
struct page ***pages, size_t maxsize,
1085-
unsigned int maxpages, size_t *start,
1086-
iov_iter_extraction_t extraction_flags)
1085+
unsigned int maxpages, size_t *start)
10871086
{
10881087
unsigned int n, gup_flags = 0;
10891088

@@ -1093,8 +1092,6 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i,
10931092
return 0;
10941093
if (maxsize > MAX_RW_COUNT)
10951094
maxsize = MAX_RW_COUNT;
1096-
if (extraction_flags & ITER_ALLOW_P2PDMA)
1097-
gup_flags |= FOLL_PCI_P2PDMA;
10981095

10991096
if (likely(user_backed_iter(i))) {
11001097
unsigned long addr;
@@ -1144,49 +1141,31 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i,
11441141
return -EFAULT;
11451142
}
11461143

1147-
ssize_t iov_iter_get_pages(struct iov_iter *i,
1148-
struct page **pages, size_t maxsize, unsigned maxpages,
1149-
size_t *start, iov_iter_extraction_t extraction_flags)
1144+
ssize_t iov_iter_get_pages2(struct iov_iter *i, struct page **pages,
1145+
size_t maxsize, unsigned maxpages, size_t *start)
11501146
{
11511147
if (!maxpages)
11521148
return 0;
11531149
BUG_ON(!pages);
11541150

1155-
return __iov_iter_get_pages_alloc(i, &pages, maxsize, maxpages,
1156-
start, extraction_flags);
1157-
}
1158-
EXPORT_SYMBOL_GPL(iov_iter_get_pages);
1159-
1160-
ssize_t iov_iter_get_pages2(struct iov_iter *i, struct page **pages,
1161-
size_t maxsize, unsigned maxpages, size_t *start)
1162-
{
1163-
return iov_iter_get_pages(i, pages, maxsize, maxpages, start, 0);
1151+
return __iov_iter_get_pages_alloc(i, &pages, maxsize, maxpages, start);
11641152
}
11651153
EXPORT_SYMBOL(iov_iter_get_pages2);
11661154

1167-
ssize_t iov_iter_get_pages_alloc(struct iov_iter *i,
1168-
struct page ***pages, size_t maxsize,
1169-
size_t *start, iov_iter_extraction_t extraction_flags)
1155+
ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i,
1156+
struct page ***pages, size_t maxsize, size_t *start)
11701157
{
11711158
ssize_t len;
11721159

11731160
*pages = NULL;
11741161

1175-
len = __iov_iter_get_pages_alloc(i, pages, maxsize, ~0U, start,
1176-
extraction_flags);
1162+
len = __iov_iter_get_pages_alloc(i, pages, maxsize, ~0U, start);
11771163
if (len <= 0) {
11781164
kvfree(*pages);
11791165
*pages = NULL;
11801166
}
11811167
return len;
11821168
}
1183-
EXPORT_SYMBOL_GPL(iov_iter_get_pages_alloc);
1184-
1185-
ssize_t iov_iter_get_pages_alloc2(struct iov_iter *i,
1186-
struct page ***pages, size_t maxsize, size_t *start)
1187-
{
1188-
return iov_iter_get_pages_alloc(i, pages, maxsize, start, 0);
1189-
}
11901169
EXPORT_SYMBOL(iov_iter_get_pages_alloc2);
11911170

11921171
size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum,

0 commit comments

Comments
 (0)