Skip to content

Commit 84c16d0

Browse files
committed
platform/x86: intel-vbtn: Stop calling "VBDL" from notify_handler
Commit 14c200b ("platform/x86: intel-vbtn: Fix missing tablet-mode-switch events") causes 2 issues on the ThinkPad X1 Tablet Gen2: 1. The ThinkPad will wake up immediately from suspend 2. When put in tablet mode SW_TABLET_MODE reverts to 0 after about 1 second Both these issues are caused by the "VBDL" ACPI method call added at the end of the notify_handler. And it never became entirely clear if this call is even necessary to fix the issue of missing tablet-mode-switch events on the Dell Inspiron 7352. Drop the "VBDL" ACPI method call again to fix the 2 issues this is causing on the ThinkPad X1 Tablet Gen2. Fixes: 14c200b ("platform/x86: intel-vbtn: Fix missing tablet-mode-switch events") Reported-by: Alexander Kobel <[email protected]> Closes: https://lore.kernel.org/platform-driver-x86/[email protected]/ Cc: [email protected] Cc: Arnold Gozum <[email protected]> Cc: [email protected] Signed-off-by: Hans de Goede <[email protected]> Tested-by: Alexander Kobel <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 8215ca5 commit 84c16d0

File tree

1 file changed

+0
-3
lines changed
  • drivers/platform/x86/intel

1 file changed

+0
-3
lines changed

drivers/platform/x86/intel/vbtn.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,6 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
200200
autorelease = val && (!ke_rel || ke_rel->type == KE_IGNORE);
201201

202202
sparse_keymap_report_event(input_dev, event, val, autorelease);
203-
204-
/* Some devices need this to report further events */
205-
acpi_evaluate_object(handle, "VBDL", NULL, NULL);
206203
}
207204

208205
/*

0 commit comments

Comments
 (0)