Skip to content

Commit 84d56f3

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: video: Change Sony Vaio VPCEH3U1E quirk to force_native
According to: https://bugzilla.kernel.org/show_bug.cgi?id=202401 the Sony Vaio VPCEH3U1E quirk was added to disable the acpi_video0 backlight interface because that was not working, so that userspace will pick the actually working native nv_backlight interface instead. With the new kernel behavior of hiding native interfaces unless acpi_video_get_backlight_type() returns native, the current video_detect_force_vendor quirk will cause the working nv_backlight interface will be disabled too. Change the quirk to video_detect_force_native to get the desired result of only registering the nv_backlight interface. After this all currently remaining force_vendor quirks in video_detect_dmi_table[] are there to prefer a vendor interface over a non working ACPI video interface, add a comment to document this. Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 9f7dd27 commit 84d56f3

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

drivers/acpi/video_detect.c

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,10 @@ static int video_detect_force_none(const struct dmi_system_id *d)
132132
}
133133

134134
static const struct dmi_system_id video_detect_dmi_table[] = {
135+
/*
136+
* Models which should use the vendor backlight interface,
137+
* because of broken ACPI video backlight control.
138+
*/
135139
{
136140
/* https://bugzilla.redhat.com/show_bug.cgi?id=1128309 */
137141
.callback = video_detect_force_vendor,
@@ -226,15 +230,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
226230
DMI_MATCH(DMI_BOARD_NAME, "NC210/NC110"),
227231
},
228232
},
229-
{
230-
/* https://bugzilla.kernel.org/show_bug.cgi?id=202401 */
231-
.callback = video_detect_force_vendor,
232-
/* Sony VPCEH3U1E */
233-
.matches = {
234-
DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
235-
DMI_MATCH(DMI_PRODUCT_NAME, "VPCEH3U1E"),
236-
},
237-
},
238233
{
239234
.callback = video_detect_force_vendor,
240235
/* Xiaomi Mi Pad 2 */
@@ -604,6 +599,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
604599
DMI_MATCH(DMI_BOARD_NAME, "N250P"),
605600
},
606601
},
602+
{
603+
/* https://bugzilla.kernel.org/show_bug.cgi?id=202401 */
604+
.callback = video_detect_force_native,
605+
/* Sony Vaio VPCEH3U1E */
606+
.matches = {
607+
DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
608+
DMI_MATCH(DMI_PRODUCT_NAME, "VPCEH3U1E"),
609+
},
610+
},
607611

608612
/*
609613
* These Toshibas have a broken acpi-video interface for brightness

0 commit comments

Comments
 (0)