Skip to content

Commit 84dea31

Browse files
tobluxbroonie
authored andcommitted
ASoC: codecs: Use min() to simplify aw_dev_dsp_update_container()
Use min() to simplify aw_dev_dsp_update_container() and improve its readability. No functional changes intended. Signed-off-by: Thorsten Blum <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 00a371a commit 84dea31

File tree

3 files changed

+6
-15
lines changed

3 files changed

+6
-15
lines changed

sound/soc/codecs/aw88166.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include <linux/firmware.h>
1212
#include <linux/gpio/consumer.h>
1313
#include <linux/i2c.h>
14+
#include <linux/minmax.h>
1415
#include <linux/regmap.h>
1516
#include <sound/soc.h>
1617
#include "aw88166.h"
@@ -909,11 +910,7 @@ static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
909910
goto error_operation;
910911

911912
for (i = 0; i < len; i += AW88166_MAX_RAM_WRITE_BYTE_SIZE) {
912-
if ((len - i) < AW88166_MAX_RAM_WRITE_BYTE_SIZE)
913-
tmp_len = len - i;
914-
else
915-
tmp_len = AW88166_MAX_RAM_WRITE_BYTE_SIZE;
916-
913+
tmp_len = min(len - i, AW88166_MAX_RAM_WRITE_BYTE_SIZE);
917914
ret = regmap_raw_write(aw_dev->regmap, AW88166_DSPMDAT_REG,
918915
&data[i], tmp_len);
919916
if (ret)

sound/soc/codecs/aw88395/aw88395_device.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
#include <linux/crc32.h>
1212
#include <linux/i2c.h>
13+
#include <linux/minmax.h>
1314
#include <linux/regmap.h>
1415
#include "aw88395_device.h"
1516
#include "aw88395_reg.h"
@@ -1114,11 +1115,7 @@ static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
11141115
goto error_operation;
11151116

11161117
for (i = 0; i < len; i += AW88395_MAX_RAM_WRITE_BYTE_SIZE) {
1117-
if ((len - i) < AW88395_MAX_RAM_WRITE_BYTE_SIZE)
1118-
tmp_len = len - i;
1119-
else
1120-
tmp_len = AW88395_MAX_RAM_WRITE_BYTE_SIZE;
1121-
1118+
tmp_len = min(len - i, AW88395_MAX_RAM_WRITE_BYTE_SIZE);
11221119
ret = regmap_raw_write(aw_dev->regmap, AW88395_DSPMDAT_REG,
11231120
&data[i], tmp_len);
11241121
if (ret)

sound/soc/codecs/aw88399.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
#include <linux/gpio/consumer.h>
1212
#include <linux/i2c.h>
1313
#include <linux/firmware.h>
14+
#include <linux/minmax.h>
1415
#include <linux/regmap.h>
1516
#include <sound/soc.h>
1617
#include "aw88399.h"
@@ -872,11 +873,7 @@ static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
872873
goto error_operation;
873874

874875
for (i = 0; i < len; i += AW88399_MAX_RAM_WRITE_BYTE_SIZE) {
875-
if ((len - i) < AW88399_MAX_RAM_WRITE_BYTE_SIZE)
876-
tmp_len = len - i;
877-
else
878-
tmp_len = AW88399_MAX_RAM_WRITE_BYTE_SIZE;
879-
876+
tmp_len = min(len - i, AW88399_MAX_RAM_WRITE_BYTE_SIZE);
880877
ret = regmap_raw_write(aw_dev->regmap, AW88399_DSPMDAT_REG,
881878
&data[i], tmp_len);
882879
if (ret)

0 commit comments

Comments
 (0)