Skip to content

Commit 84e36a9

Browse files
Ben Widawskydjbw
authored andcommitted
cxl/pci: Remove pci request/release regions
Quoting Dan, "... the request + release regions should probably just be dropped. It's not like any of the register enumeration would collide with someone else who already has the registers mapped. The collision only comes when the registers are mapped for their final usage, and that will have more precision in the request." Suggested-by: Dan Williams <[email protected]> Signed-off-by: Ben Widawsky <[email protected]> Link: https://lore.kernel.org/r/163379785872.692348.8981679111988251260.stgit@dwillia2-desk3.amr.corp.intel.com Signed-off-by: Dan Williams <[email protected]>
1 parent ca76a3a commit 84e36a9

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/cxl/pci.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -453,9 +453,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
453453
return -ENXIO;
454454
}
455455

456-
if (pci_request_mem_regions(pdev, pci_name(pdev)))
457-
return -ENODEV;
458-
459456
/* Get the size of the Register Locator DVSEC */
460457
pci_read_config_dword(pdev, regloc + PCI_DVSEC_HEADER1, &regloc_size);
461458
regloc_size = FIELD_GET(PCI_DVSEC_HEADER1_LENGTH_MASK, regloc_size);
@@ -499,8 +496,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
499496
n_maps++;
500497
}
501498

502-
pci_release_mem_regions(pdev);
503-
504499
for (i = 0; i < n_maps; i++) {
505500
ret = cxl_map_regs(cxlm, &maps[i]);
506501
if (ret)

0 commit comments

Comments
 (0)