Skip to content

Commit 84ec7c2

Browse files
committed
rcu: Allow up to five minutes expedited RCU CPU stall-warning timeouts
The maximum value of RCU CPU stall-warning timeouts has historically been five minutes (300 seconds). However, the recently introduced expedited RCU CPU stall-warning timeout is instead limited to 21 seconds. This causes problems for CI/fuzzing services such as syzkaller by obscuring the issue in question with expedited RCU CPU stall-warning timeout splats. This commit therefore sets the RCU_EXP_CPU_STALL_TIMEOUT Kconfig options upper bound to 300000 milliseconds, which is 300 seconds (AKA 5 minutes). [ paulmck: Apply feedback from Hillf Danton. ] [ paulmck: Apply feedback from Geert Uytterhoeven. ] Reported-by: Dave Chinner <[email protected]> Reported-by: Dmitry Vyukov <[email protected]> Tested-by: Dmitry Vyukov <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 3ab955d commit 84ec7c2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

kernel/rcu/Kconfig.debug

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ config RCU_CPU_STALL_TIMEOUT
8282
config RCU_EXP_CPU_STALL_TIMEOUT
8383
int "Expedited RCU CPU stall timeout in milliseconds"
8484
depends on RCU_STALL_COMMON
85-
range 0 21000
85+
range 0 300000
8686
default 0
8787
help
8888
If a given expedited RCU grace period extends more than the

kernel/rcu/tree_stall.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ int rcu_exp_jiffies_till_stall_check(void)
3939
// CONFIG_RCU_EXP_CPU_STALL_TIMEOUT, so check the allowed range.
4040
// The minimum clamped value is "2UL", because at least one full
4141
// tick has to be guaranteed.
42-
till_stall_check = clamp(msecs_to_jiffies(cpu_stall_timeout), 2UL, 21UL * HZ);
42+
till_stall_check = clamp(msecs_to_jiffies(cpu_stall_timeout), 2UL, 300UL * HZ);
4343

4444
if (cpu_stall_timeout && jiffies_to_msecs(till_stall_check) != cpu_stall_timeout)
4545
WRITE_ONCE(rcu_exp_cpu_stall_timeout, jiffies_to_msecs(till_stall_check));

0 commit comments

Comments
 (0)