Skip to content

Commit 8520501

Browse files
committed
irqchip: or1k-pic: Undefine mask_ack for level triggered hardware
The mask_ack operation clears the interrupt by writing to the PICSR register. This we don't want for level triggered interrupt because it does not actually clear the interrupt on the source hardware. This was causing issues in qemu with multi core setups where interrupts would continue to fire even though they had been cleared in PICSR. Just remove the mask_ack operation. Acked-by: Marc Zyngier <[email protected]> Signed-off-by: Stafford Horne <[email protected]>
1 parent 03c765b commit 8520501

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/irqchip/irq-or1k-pic.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ static struct or1k_pic_dev or1k_pic_level = {
6666
.name = "or1k-PIC-level",
6767
.irq_unmask = or1k_pic_unmask,
6868
.irq_mask = or1k_pic_mask,
69-
.irq_mask_ack = or1k_pic_mask_ack,
7069
},
7170
.handle = handle_level_irq,
7271
.flags = IRQ_LEVEL | IRQ_NOPROBE,

0 commit comments

Comments
 (0)