Skip to content

Commit 853eab6

Browse files
wmealinggregkh
authored andcommitted
Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"
Turns out that the permissions for 0400 really are what we want here, otherwise any user can read from this file. [fixed formatting, added changelog, and made attribute static - gregkh] Reported-by: Wade Mealing <[email protected]> Cc: stable <[email protected]> Fixes: f40609d ("zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()") Link: https://bugzilla.redhat.com/show_bug.cgi?id=1847832 Reviewed-by: Steffen Maier <[email protected]> Acked-by: Minchan Kim <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e852c2c commit 853eab6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/block/zram/zram_drv.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2021,7 +2021,8 @@ static ssize_t hot_add_show(struct class *class,
20212021
return ret;
20222022
return scnprintf(buf, PAGE_SIZE, "%d\n", ret);
20232023
}
2024-
static CLASS_ATTR_RO(hot_add);
2024+
static struct class_attribute class_attr_hot_add =
2025+
__ATTR(hot_add, 0400, hot_add_show, NULL);
20252026

20262027
static ssize_t hot_remove_store(struct class *class,
20272028
struct class_attribute *attr,

0 commit comments

Comments
 (0)