Skip to content

Commit 85578bb

Browse files
stephan-ghbroonie
authored andcommitted
ASoC: msm8916-wcd-digital: Reset RX interpolation path after use
For some reason, attempting to route audio through QDSP6 on MSM8916 causes the RX interpolation path to get "stuck" after playing audio a few times. In this situation, the analog codec part is still working, but the RX path in the digital codec stops working, so you only hear the analog parts powering up. After a reboot everything works again. So far I was not able to reproduce the problem when using lpass-cpu. The downstream kernel driver avoids this by resetting the RX interpolation path after use. In mainline we do something similar for the TX decimator (LPASS_CDC_CLK_TX_RESET_B1_CTL), but the interpolator reset (LPASS_CDC_CLK_RX_RESET_CTL) got lost when the msm8916-wcd driver was split into analog and digital. Fix this problem by adding the reset to msm8916_wcd_digital_enable_interpolator(). Fixes: 150db8c ("ASoC: codecs: Add msm8916-wcd digital codec") Cc: Srinivas Kandagatla <[email protected]> Signed-off-by: Stephan Gerhold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 057efcf commit 85578bb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

sound/soc/codecs/msm8916-wcd-digital.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -586,6 +586,12 @@ static int msm8916_wcd_digital_enable_interpolator(
586586
snd_soc_component_write(component, rx_gain_reg[w->shift],
587587
snd_soc_component_read32(component, rx_gain_reg[w->shift]));
588588
break;
589+
case SND_SOC_DAPM_POST_PMD:
590+
snd_soc_component_update_bits(component, LPASS_CDC_CLK_RX_RESET_CTL,
591+
1 << w->shift, 1 << w->shift);
592+
snd_soc_component_update_bits(component, LPASS_CDC_CLK_RX_RESET_CTL,
593+
1 << w->shift, 0x0);
594+
break;
589595
}
590596
return 0;
591597
}

0 commit comments

Comments
 (0)