Skip to content

Commit 8580485

Browse files
committed
ata: pata_serverworks: Do not use the term blacklist
Let's not use the term blacklist in the function serverworks_osb4_filter() documentation comment and rather simply refer to what that function looks at: the list of devices with groken UDMA5. While at it, also constify the values of the csb_bad_ata100 array. Of note is that all of this should probably be handled using libata quirk mechanism but it is unclear if these UDMA5 quirks are specific to this controller only. Signed-off-by: Damien Le Moal <[email protected]> Reviewed-by: Niklas Cassel <[email protected]> Reviewed-by: Igor Pylypiv <[email protected]>
1 parent 58157d6 commit 8580485

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

drivers/ata/pata_serverworks.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,11 @@
4646
#define SVWKS_CSB5_REVISION_NEW 0x92 /* min PCI_REVISION_ID for UDMA5 (A2.0) */
4747
#define SVWKS_CSB6_REVISION 0xa0 /* min PCI_REVISION_ID for UDMA4 (A1.0) */
4848

49-
/* Seagate Barracuda ATA IV Family drives in UDMA mode 5
50-
* can overrun their FIFOs when used with the CSB5 */
51-
52-
static const char *csb_bad_ata100[] = {
49+
/*
50+
* Seagate Barracuda ATA IV Family drives in UDMA mode 5
51+
* can overrun their FIFOs when used with the CSB5.
52+
*/
53+
static const char * const csb_bad_ata100[] = {
5354
"ST320011A",
5455
"ST340016A",
5556
"ST360021A",
@@ -163,10 +164,11 @@ static unsigned int serverworks_osb4_filter(struct ata_device *adev, unsigned in
163164
* @adev: ATA device
164165
* @mask: Mask of proposed modes
165166
*
166-
* Check the blacklist and disable UDMA5 if matched
167+
* Check the list of devices with broken UDMA5 and
168+
* disable UDMA5 if matched.
167169
*/
168-
169-
static unsigned int serverworks_csb_filter(struct ata_device *adev, unsigned int mask)
170+
static unsigned int serverworks_csb_filter(struct ata_device *adev,
171+
unsigned int mask)
170172
{
171173
const char *p;
172174
char model_num[ATA_ID_PROD_LEN + 1];

0 commit comments

Comments
 (0)