Skip to content

Commit 85d93b1

Browse files
geertuojeda
authored andcommitted
auxdisplay: ht16k33: Move delayed work
Move delayed_work from ht16k33_fbdev to ht16k33_priv, as it is not specific to dot-matrix displays, but common to all display types. Signed-off-by: Geert Uytterhoeven <[email protected]> Acked-by: Robin van der Gracht <[email protected]> Signed-off-by: Miguel Ojeda <[email protected]>
1 parent d08a44d commit 85d93b1

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

drivers/auxdisplay/ht16k33.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ struct ht16k33_fbdev {
6565
uint32_t refresh_rate;
6666
uint8_t *buffer;
6767
uint8_t *cache;
68-
struct delayed_work work;
6968
};
7069

7170
struct ht16k33_priv {
7271
struct i2c_client *client;
72+
struct delayed_work work;
7373
struct ht16k33_keypad keypad;
7474
struct ht16k33_fbdev fbdev;
7575
};
@@ -117,18 +117,17 @@ static void ht16k33_fb_queue(struct ht16k33_priv *priv)
117117
{
118118
struct ht16k33_fbdev *fbdev = &priv->fbdev;
119119

120-
schedule_delayed_work(&fbdev->work, HZ / fbdev->refresh_rate);
120+
schedule_delayed_work(&priv->work, HZ / fbdev->refresh_rate);
121121
}
122122

123123
/*
124124
* This gets the fb data from cache and copies it to ht16k33 display RAM
125125
*/
126126
static void ht16k33_fb_update(struct work_struct *work)
127127
{
128-
struct ht16k33_fbdev *fbdev =
129-
container_of(work, struct ht16k33_fbdev, work.work);
130-
struct ht16k33_priv *priv =
131-
container_of(fbdev, struct ht16k33_priv, fbdev);
128+
struct ht16k33_priv *priv = container_of(work, struct ht16k33_priv,
129+
work.work);
130+
struct ht16k33_fbdev *fbdev = &priv->fbdev;
132131

133132
uint8_t *p1, *p2;
134133
int len, pos = 0, first = -1;
@@ -472,7 +471,7 @@ static int ht16k33_probe(struct i2c_client *client)
472471
}
473472
fb_bl_default_curve(fbdev->info, 0, MIN_BRIGHTNESS, MAX_BRIGHTNESS);
474473

475-
INIT_DELAYED_WORK(&fbdev->work, ht16k33_fb_update);
474+
INIT_DELAYED_WORK(&priv->work, ht16k33_fb_update);
476475
fbdev->info->fbops = &ht16k33_fb_ops;
477476
fbdev->info->screen_base = (char __iomem *) fbdev->buffer;
478477
fbdev->info->screen_size = HT16K33_FB_SIZE;
@@ -512,7 +511,7 @@ static int ht16k33_remove(struct i2c_client *client)
512511
struct ht16k33_priv *priv = i2c_get_clientdata(client);
513512
struct ht16k33_fbdev *fbdev = &priv->fbdev;
514513

515-
cancel_delayed_work_sync(&fbdev->work);
514+
cancel_delayed_work_sync(&priv->work);
516515
unregister_framebuffer(fbdev->info);
517516
framebuffer_release(fbdev->info);
518517
free_page((unsigned long) fbdev->buffer);

0 commit comments

Comments
 (0)