Skip to content

Commit 85e9b88

Browse files
vaverinkraxel
authored andcommitted
drm/qxl: qxl_release leak in qxl_draw_dirty_fb()
ret should be changed to release allocated struct qxl_release Cc: [email protected] Fixes: 8002db6 ("qxl: convert qxl driver to proper use for reservations") Signed-off-by: Vasily Averin <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
1 parent 45c5d2a commit 85e9b88

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/qxl/qxl_draw.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,10 @@ void qxl_draw_dirty_fb(struct qxl_device *qdev,
209209
goto out_release_backoff;
210210

211211
rects = drawable_set_clipping(qdev, num_clips, clips_bo);
212-
if (!rects)
212+
if (!rects) {
213+
ret = -EINVAL;
213214
goto out_release_backoff;
214-
215+
}
215216
drawable = (struct qxl_drawable *)qxl_release_map(qdev, release);
216217

217218
drawable->clip.type = SPICE_CLIP_TYPE_RECTS;

0 commit comments

Comments
 (0)