Skip to content

Commit 861f96a

Browse files
LuBaolujgunthorpe
authored andcommitted
iommufd: Remove IOMMUFD_PAGE_RESP_FAILURE
The response code of IOMMUFD_PAGE_RESP_FAILURE was defined to be equivalent to the "Response Failure" in PCI spec, section 10.4.2.1. This response code indicates that one or more pages within the associated request group have encountered or caused an unrecoverable error. Therefore, this response disables the PRI at the function. Modern I/O virtualization technologies, like SR-IOV, share PRI among the assignable device units. Therefore, a response failure on one unit might cause I/O failure on other units. Remove this response code so that user space can only respond with SUCCESS or INVALID. The VMM is recommended to emulate a failure response as a PRI reset, or PRI disable and changing to a non-PRI domain. Fixes: c714f15 ("iommufd: Add fault and response message definitions") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lu Baolu <[email protected]> Reviewed-by: Kevin Tian <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent a11dda7 commit 861f96a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

include/uapi/linux/iommufd.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -765,14 +765,10 @@ struct iommu_hwpt_pgfault {
765765
* @IOMMUFD_PAGE_RESP_INVALID: Could not handle this fault, don't retry the
766766
* access. This is the "Invalid Request" in PCI
767767
* 10.4.2.1.
768-
* @IOMMUFD_PAGE_RESP_FAILURE: General error. Drop all subsequent faults from
769-
* this device if possible. This is the "Response
770-
* Failure" in PCI 10.4.2.1.
771768
*/
772769
enum iommufd_page_response_code {
773770
IOMMUFD_PAGE_RESP_SUCCESS = 0,
774771
IOMMUFD_PAGE_RESP_INVALID,
775-
IOMMUFD_PAGE_RESP_FAILURE,
776772
};
777773

778774
/**

0 commit comments

Comments
 (0)