Skip to content

Commit 862c135

Browse files
Junhao HeSuzuki K Poulose
authored andcommitted
coresight: ultrasoc-smb: Fix uninitialized before use buf_hw_base
In smb_reset_buffer, the sdb->buf_hw_base variable is uninitialized before use, which initializes it in smb_init_data_buffer. And the SMB regiester are set in smb_config_inport. So move the call after smb_config_inport. Fixes: 06f5c29 ("drivers/coresight: Add UltraSoc System Memory Buffer driver") Signed-off-by: Junhao He <[email protected]> Reviewed-by: James Clark <[email protected]> Signed-off-by: Suzuki K Poulose <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 830a7f5 commit 862c135

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/hwtracing/coresight/ultrasoc-smb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,6 @@ static int smb_init_data_buffer(struct platform_device *pdev,
477477
static void smb_init_hw(struct smb_drv_data *drvdata)
478478
{
479479
smb_disable_hw(drvdata);
480-
smb_reset_buffer(drvdata);
481480

482481
writel(SMB_LB_CFG_LO_DEFAULT, drvdata->base + SMB_LB_CFG_LO_REG);
483482
writel(SMB_LB_CFG_HI_DEFAULT, drvdata->base + SMB_LB_CFG_HI_REG);
@@ -587,6 +586,7 @@ static int smb_probe(struct platform_device *pdev)
587586
if (ret)
588587
return ret;
589588

589+
smb_reset_buffer(drvdata);
590590
platform_set_drvdata(pdev, drvdata);
591591
spin_lock_init(&drvdata->spinlock);
592592
drvdata->pid = -1;

0 commit comments

Comments
 (0)