Skip to content

Commit 86f29c7

Browse files
committed
ASoC: dmaengine: Document support for TX only or RX only streams
We intentionally do not return an error if we get a permanent failure from dma_request_chan() in order to support systems which have TX only or RX only channels. Add a comment documenting this. Reported-by: Andy Shevchenko <[email protected]> Signed-off-by: Mark Brown <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent b899e4f commit 86f29c7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

sound/soc/soc-generic-dmaengine-pcm.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,11 @@ static int dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm,
386386
name = config->chan_names[i];
387387
chan = dma_request_chan(dev, name);
388388
if (IS_ERR(chan)) {
389+
/*
390+
* Only report probe deferral errors, channels
391+
* might not be present for devices that
392+
* support only TX or only RX.
393+
*/
389394
if (PTR_ERR(chan) == -EPROBE_DEFER)
390395
return -EPROBE_DEFER;
391396
pcm->chan[i] = NULL;

0 commit comments

Comments
 (0)