Skip to content

Commit 8715c91

Browse files
anarsoulwens
authored andcommitted
arm64: dts: allwinner: a64: explicitly assign clock parent for TCON0
TCON0 seems to need a different clock parent depending on output type. For RGB it has to be PLL-VIDEO0-2X, while for DSI it has to be PLL-MIPI, so select it explicitly. Video output doesn't work if incorrect clock is assigned. On my Pinebook I manually configured PLL-VIDEO0-2X and PLL-MIPI to the same rate, and while video output works fine with PLL-VIDEO0-2X, it doesn't work at all (as in no picture) with PLL-MIPI. Fixes: ca1170b ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux") Reviewed-by: Dragan Simic <[email protected]> Reviewed-by: Chen-Yu Tsai <[email protected]> Tested-by: Frank Oltmanns <[email protected]> # on PinePhone Tested-by: Stuart Gathman <[email protected]> # on OG Pinebook Signed-off-by: Vasily Khoruzhick <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Chen-Yu Tsai <[email protected]>
1 parent dbfda1f commit 8715c91

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,8 @@
390390
&tcon0 {
391391
pinctrl-names = "default";
392392
pinctrl-0 = <&lcd_rgb666_pins>;
393+
assigned-clocks = <&ccu CLK_TCON0>;
394+
assigned-clock-parents = <&ccu CLK_PLL_VIDEO0_2X>;
393395

394396
status = "okay";
395397
};

arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,8 @@
369369
&tcon0 {
370370
pinctrl-names = "default";
371371
pinctrl-0 = <&lcd_rgb666_pins>;
372+
assigned-clocks = <&ccu CLK_TCON0>;
373+
assigned-clock-parents = <&ccu CLK_PLL_VIDEO0_2X>;
372374

373375
status = "okay";
374376
};

arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,8 @@
445445
clock-names = "ahb", "tcon-ch0";
446446
clock-output-names = "tcon-data-clock";
447447
#clock-cells = <0>;
448+
assigned-clocks = <&ccu CLK_TCON0>;
449+
assigned-clock-parents = <&ccu CLK_PLL_MIPI>;
448450
resets = <&ccu RST_BUS_TCON0>, <&ccu RST_BUS_LVDS>;
449451
reset-names = "lcd", "lvds";
450452

0 commit comments

Comments
 (0)