Skip to content

Commit 8787f6f

Browse files
vsyrjalarodrigovivi
authored andcommitted
Revert "drm/i915/display: Re-add check for low voltage sku for max dp source rate"
This reverts commit d592983. With the Parade PS8461E MUX workaround (WaEdpLinkRateDataReload) implemented we can get finally rid of the is_low_voltage_sku() check that incorrectly prevents many machines from using the 8.1Gpbs link rate. Cc: Jason A. Donenfeld <[email protected]> Cc: Ankit Nautiyal <[email protected]> Cc: Jani Nikula <[email protected]> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5272 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6323 Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6205 Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Tested-by: Aaron Ma <[email protected]> Tested-by: Jason A. Donenfeld <[email protected]> Reviewed-by: Jani Nikula <[email protected]> (cherry picked from commit 483e3d8) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent d654f60 commit 8787f6f

File tree

1 file changed

+3
-29
lines changed

1 file changed

+3
-29
lines changed

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -389,47 +389,21 @@ static int dg2_max_source_rate(struct intel_dp *intel_dp)
389389
return intel_dp_is_edp(intel_dp) ? 810000 : 1350000;
390390
}
391391

392-
static bool is_low_voltage_sku(struct drm_i915_private *i915, enum phy phy)
393-
{
394-
u32 voltage;
395-
396-
voltage = intel_de_read(i915, ICL_PORT_COMP_DW3(phy)) & VOLTAGE_INFO_MASK;
397-
398-
return voltage == VOLTAGE_INFO_0_85V;
399-
}
400-
401392
static int icl_max_source_rate(struct intel_dp *intel_dp)
402393
{
403394
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
404395
struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
405396
enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port);
406397

407-
if (intel_phy_is_combo(dev_priv, phy) &&
408-
(is_low_voltage_sku(dev_priv, phy) || !intel_dp_is_edp(intel_dp)))
398+
if (intel_phy_is_combo(dev_priv, phy) && !intel_dp_is_edp(intel_dp))
409399
return 540000;
410400

411401
return 810000;
412402
}
413403

414404
static int ehl_max_source_rate(struct intel_dp *intel_dp)
415405
{
416-
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
417-
struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
418-
enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port);
419-
420-
if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy))
421-
return 540000;
422-
423-
return 810000;
424-
}
425-
426-
static int dg1_max_source_rate(struct intel_dp *intel_dp)
427-
{
428-
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
429-
struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
430-
enum phy phy = intel_port_to_phy(i915, dig_port->base.port);
431-
432-
if (intel_phy_is_combo(i915, phy) && is_low_voltage_sku(i915, phy))
406+
if (intel_dp_is_edp(intel_dp))
433407
return 540000;
434408

435409
return 810000;
@@ -491,7 +465,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp)
491465
max_rate = dg2_max_source_rate(intel_dp);
492466
else if (IS_ALDERLAKE_P(dev_priv) || IS_ALDERLAKE_S(dev_priv) ||
493467
IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
494-
max_rate = dg1_max_source_rate(intel_dp);
468+
max_rate = 810000;
495469
else if (IS_JSL_EHL(dev_priv))
496470
max_rate = ehl_max_source_rate(intel_dp);
497471
else

0 commit comments

Comments
 (0)