Skip to content

Commit 87e2a15

Browse files
Matthew Wilcox (Oracle)Jaegeuk Kim
authored andcommitted
f2fs: Convert submit tracepoints to take a folio
Remove accesses to page->index and page->mapping as well as unnecessary calls to page_file_mapping(). Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent ac86690 commit 87e2a15

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

fs/f2fs/data.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio)
697697
META_GENERIC : DATA_GENERIC_ENHANCE)))
698698
return -EFSCORRUPTED;
699699

700-
trace_f2fs_submit_page_bio(page, fio);
700+
trace_f2fs_submit_folio_bio(page_folio(page), fio);
701701

702702
/* Allocate a new bio */
703703
bio = __bio_alloc(fio, 1);
@@ -894,7 +894,7 @@ int f2fs_merge_page_bio(struct f2fs_io_info *fio)
894894
__is_meta_io(fio) ? META_GENERIC : DATA_GENERIC))
895895
return -EFSCORRUPTED;
896896

897-
trace_f2fs_submit_page_bio(page, fio);
897+
trace_f2fs_submit_folio_bio(page_folio(page), fio);
898898

899899
if (bio && !page_is_mergeable(fio->sbi, bio, *fio->last_block,
900900
fio->new_blkaddr))
@@ -1018,7 +1018,7 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
10181018

10191019
io->last_block_in_bio = fio->new_blkaddr;
10201020

1021-
trace_f2fs_submit_page_write(fio->page, fio);
1021+
trace_f2fs_submit_folio_write(page_folio(fio->page), fio);
10221022
#ifdef CONFIG_BLK_DEV_ZONED
10231023
if (f2fs_sb_has_blkzoned(sbi) && btype < META &&
10241024
is_end_zone_blkaddr(sbi, fio->new_blkaddr)) {

include/trace/events/f2fs.h

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,11 +1119,11 @@ TRACE_EVENT(f2fs_reserve_new_blocks,
11191119
(unsigned long long)__entry->count)
11201120
);
11211121

1122-
DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
1122+
DECLARE_EVENT_CLASS(f2fs__submit_folio_bio,
11231123

1124-
TP_PROTO(struct page *page, struct f2fs_io_info *fio),
1124+
TP_PROTO(struct folio *folio, struct f2fs_io_info *fio),
11251125

1126-
TP_ARGS(page, fio),
1126+
TP_ARGS(folio, fio),
11271127

11281128
TP_STRUCT__entry(
11291129
__field(dev_t, dev)
@@ -1138,9 +1138,9 @@ DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
11381138
),
11391139

11401140
TP_fast_assign(
1141-
__entry->dev = page_file_mapping(page)->host->i_sb->s_dev;
1142-
__entry->ino = page_file_mapping(page)->host->i_ino;
1143-
__entry->index = page->index;
1141+
__entry->dev = folio->mapping->host->i_sb->s_dev;
1142+
__entry->ino = folio->mapping->host->i_ino;
1143+
__entry->index = folio->index;
11441144
__entry->old_blkaddr = fio->old_blkaddr;
11451145
__entry->new_blkaddr = fio->new_blkaddr;
11461146
__entry->op = fio->op;
@@ -1149,7 +1149,7 @@ DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
11491149
__entry->type = fio->type;
11501150
),
11511151

1152-
TP_printk("dev = (%d,%d), ino = %lu, page_index = 0x%lx, "
1152+
TP_printk("dev = (%d,%d), ino = %lu, folio_index = 0x%lx, "
11531153
"oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s(%s), type = %s_%s",
11541154
show_dev_ino(__entry),
11551155
(unsigned long)__entry->index,
@@ -1160,22 +1160,22 @@ DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
11601160
show_block_type(__entry->type))
11611161
);
11621162

1163-
DEFINE_EVENT_CONDITION(f2fs__submit_page_bio, f2fs_submit_page_bio,
1163+
DEFINE_EVENT_CONDITION(f2fs__submit_folio_bio, f2fs_submit_folio_bio,
11641164

1165-
TP_PROTO(struct page *page, struct f2fs_io_info *fio),
1165+
TP_PROTO(struct folio *folio, struct f2fs_io_info *fio),
11661166

1167-
TP_ARGS(page, fio),
1167+
TP_ARGS(folio, fio),
11681168

1169-
TP_CONDITION(page->mapping)
1169+
TP_CONDITION(folio->mapping)
11701170
);
11711171

1172-
DEFINE_EVENT_CONDITION(f2fs__submit_page_bio, f2fs_submit_page_write,
1172+
DEFINE_EVENT_CONDITION(f2fs__submit_folio_bio, f2fs_submit_folio_write,
11731173

1174-
TP_PROTO(struct page *page, struct f2fs_io_info *fio),
1174+
TP_PROTO(struct folio *folio, struct f2fs_io_info *fio),
11751175

1176-
TP_ARGS(page, fio),
1176+
TP_ARGS(folio, fio),
11771177

1178-
TP_CONDITION(page->mapping)
1178+
TP_CONDITION(folio->mapping)
11791179
);
11801180

11811181
DECLARE_EVENT_CLASS(f2fs__bio,

0 commit comments

Comments
 (0)