Skip to content

Commit 8802183

Browse files
sean-jcbonzini
authored andcommitted
Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE_ATTRIBUTE() usage"
Remove coccinelle's recommendation to use DEFINE_DEBUGFS_ATTRIBUTE() instead of DEFINE_SIMPLE_ATTRIBUTE(). Regardless of whether or not the "significant overhead" incurred by debugfs_create_file() is actually meaningful, warnings from the script have led to a rash of low-quality patches that have sowed confusion and consumed maintainer time for little to no benefit. There have been no less than four attempts to "fix" KVM, and a quick search on lore shows that KVM is not alone. This reverts commit 5103068. Link: https://lore.kernel.org/all/[email protected] Link: https://lore.kernel.org/all/[email protected] Link: https://lkml.kernel.org/r/20230706072954.4881-1-duminjie%40vivo.com Link: https://lore.kernel.org/all/[email protected] Link: https://lore.kernel.org/all/Y2ENJJ1YiSg5oHiy@orome Link: https://lore.kernel.org/all/[email protected] Suggested-by: Paolo Bonzini <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Sean Christopherson <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 211c018 commit 8802183

File tree

1 file changed

+0
-68
lines changed

1 file changed

+0
-68
lines changed

scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Lines changed: 0 additions & 68 deletions
This file was deleted.

0 commit comments

Comments
 (0)