Skip to content

Commit 8807e15

Browse files
qzhuo2aegl
authored andcommitted
EDAC, {skx,i10nm}: Use CPU stepping macro to pass configurations
Use the X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS() macro to pass CPU stepping specific configurations to {skx,i10nm}_init(), so can delete the CPU stepping check from 10nm_init(). Signed-off-by: Qiuxu Zhuo <[email protected]> Signed-off-by: Tony Luck <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent e9ff663 commit 8807e15

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

drivers/edac/i10nm_base.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,11 @@ static struct res_config i10nm_cfg1 = {
135135
};
136136

137137
static const struct x86_cpu_id i10nm_cpuids[] = {
138-
X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_D, &i10nm_cfg0),
139-
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, &i10nm_cfg0),
140-
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, &i10nm_cfg1),
138+
X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(ATOM_TREMONT_D, X86_STEPPINGS(0x0, 0x3), &i10nm_cfg0),
139+
X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(ATOM_TREMONT_D, X86_STEPPINGS(0x4, 0xf), &i10nm_cfg1),
140+
X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(ICELAKE_X, X86_STEPPINGS(0x0, 0x3), &i10nm_cfg0),
141+
X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(ICELAKE_X, X86_STEPPINGS(0x4, 0xf), &i10nm_cfg1),
142+
X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(ICELAKE_D, X86_STEPPINGS(0x0, 0xf), &i10nm_cfg1),
141143
{}
142144
};
143145
MODULE_DEVICE_TABLE(x86cpu, i10nm_cpuids);
@@ -264,10 +266,6 @@ static int __init i10nm_init(void)
264266

265267
cfg = (struct res_config *)id->driver_data;
266268

267-
/* Newer steppings have different offset for ATOM_TREMONT_D/ICELAKE_X */
268-
if (boot_cpu_data.x86_stepping >= 4)
269-
cfg->busno_cfg_offset = 0xd0;
270-
271269
rc = skx_get_hi_lo(0x09a2, off, &tolm, &tohm);
272270
if (rc)
273271
return rc;

drivers/edac/skx_base.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ static struct res_config skx_cfg = {
164164
};
165165

166166
static const struct x86_cpu_id skx_cpuids[] = {
167-
X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, &skx_cfg),
167+
X86_MATCH_INTEL_FAM6_MODEL_STEPPINGS(SKYLAKE_X, X86_STEPPINGS(0x0, 0xf), &skx_cfg),
168168
{ }
169169
};
170170
MODULE_DEVICE_TABLE(x86cpu, skx_cpuids);

0 commit comments

Comments
 (0)