Skip to content

Commit 8824557

Browse files
DanielMatyasgroeck
authored andcommitted
hwmon: (max31827) Modify conversion wait time
There is nothing in the datasheet indicating that the 1ms error is needed and I didn't encounter any error during testing with 140ms wait time. Signed-off-by: Daniel Matyas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]>
1 parent 9ca6696 commit 8824557

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Documentation/hwmon/max31827.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ the conversion frequency to 1 conv/s. The conversion time varies depending on
7373
the resolution. The conversion time doubles with every bit of increased
7474
resolution. For 10 bit resolution 35ms are needed, while for 12 bit resolution
7575
(default) 140ms. When chip is in shutdown mode and a read operation is
76-
requested, one-shot is triggered, the device waits for 140 (conversion time) + 1
77-
(error) ms, and only after that is the temperature value register read.
76+
requested, one-shot is triggered, the device waits for 140 (conversion time) ms,
77+
and only after that is the temperature value register read.
7878

7979
The LSB of the temperature values is 0.0625 degrees Celsius, but the values of
8080
the temperatures are displayed in milli-degrees. This means, that some data is

drivers/hwmon/max31827.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#define MAX31827_CONFIGURATION_U_TEMP_STAT_MASK BIT(14)
2626
#define MAX31827_CONFIGURATION_O_TEMP_STAT_MASK BIT(15)
2727

28-
#define MAX31827_12_BIT_CNV_TIME 141
28+
#define MAX31827_12_BIT_CNV_TIME 140
2929

3030
#define MAX31827_16_BIT_TO_M_DGR(x) (sign_extend32(x, 15) * 1000 / 16)
3131
#define MAX31827_M_DGR_TO_16_BIT(x) (((x) << 4) / 1000)

0 commit comments

Comments
 (0)