Skip to content

Commit 8844f46

Browse files
lumagAbhinav Kumar
authored andcommitted
drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible
There is little point in using %ps to print a value known to be NULL. On the other hand it makes sense to print the callback symbol in the 'invalid IRQ' message. Correct those two error messages to make more sense. Fixes: 6893199 ("drm/msm/dpu: stop using raw IRQ indices in the kernel output") Signed-off-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Marijn Suijten <[email protected]> Reviewed-by: Abhinav Kumar <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/585565/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Abhinav Kumar <[email protected]>
1 parent ee15c8b commit 8844f46

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -525,14 +525,14 @@ int dpu_core_irq_register_callback(struct dpu_kms *dpu_kms,
525525
int ret;
526526

527527
if (!irq_cb) {
528-
DPU_ERROR("invalid IRQ=[%d, %d] irq_cb:%ps\n",
529-
DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx), irq_cb);
528+
DPU_ERROR("IRQ=[%d, %d] NULL callback\n",
529+
DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx));
530530
return -EINVAL;
531531
}
532532

533533
if (!dpu_core_irq_is_valid(irq_idx)) {
534-
DPU_ERROR("invalid IRQ=[%d, %d]\n",
535-
DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx));
534+
DPU_ERROR("invalid IRQ=[%d, %d] irq_cb:%ps\n",
535+
DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx), irq_cb);
536536
return -EINVAL;
537537
}
538538

0 commit comments

Comments
 (0)