Skip to content

Commit 889a50a

Browse files
Yang Yingliangvireshk
authored andcommitted
cpufreq: sun50i: Switch to use dev_err_probe() helper
In the probe path, convert pr_err() to dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path. Signed-off-by: Yang Yingliang <[email protected]> Signed-off-by: Viresh Kumar <[email protected]>
1 parent d78be40 commit 889a50a

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/cpufreq/sun50i-cpufreq-nvmem.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,9 @@ static int sun50i_cpufreq_get_efuse(u32 *versions)
5656

5757
speedbin_nvmem = of_nvmem_cell_get(np, NULL);
5858
of_node_put(np);
59-
if (IS_ERR(speedbin_nvmem)) {
60-
if (PTR_ERR(speedbin_nvmem) != -EPROBE_DEFER)
61-
pr_err("Could not get nvmem cell: %ld\n",
62-
PTR_ERR(speedbin_nvmem));
63-
return PTR_ERR(speedbin_nvmem);
64-
}
59+
if (IS_ERR(speedbin_nvmem))
60+
return dev_err_probe(cpu_dev, PTR_ERR(speedbin_nvmem),
61+
"Could not get nvmem cell\n");
6562

6663
speedbin = nvmem_cell_read(speedbin_nvmem, &len);
6764
nvmem_cell_put(speedbin_nvmem);

0 commit comments

Comments
 (0)